The Wayback Machine - https://web.archive.org/web/20200928163002/https://github.com/wordpress-mobile/WordPress-iOS/pull/6869
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle publicize connection switch on cell tapping #6869

Merged
merged 1 commit into from Mar 15, 2017

Conversation

@elibud
Copy link
Contributor

elibud commented Mar 13, 2017

Enabling/disabling publicize connections was being handled at the cell's UISwitch level, now it is handled when tapping on the publicize cells.

Fixes #6850

To test:
Create a new post in a blog with configured publicize connections.
Go to the post options and tap on the publicize cells to enable/disable them.

Needs review: @astralbodies

Enabling/disabling connections was being handled at the UISwitch level, now it is handled at a cell level (when the cell is tapped)
@elibud elibud added this to the 7.3 ❄️ milestone Mar 13, 2017
@elibud elibud self-assigned this Mar 13, 2017
@elibud elibud requested a review from astralbodies Mar 13, 2017
@elibud elibud assigned astralbodies and elibud and unassigned elibud Mar 13, 2017
Copy link
Member

astralbodies left a comment

Nice!! :shipit:

@elibud elibud merged commit 3def787 into develop Mar 15, 2017
1 check passed
1 check passed
Buddybuild : WordPress/57a120bbe0f5520100e11c19 Build succeeded
Details
@elibud elibud deleted the issue/6850-tapping-publicize-rows-toggles-switch branch Mar 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.