Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upChange logo URL for Heroku and Scalingo #4476
+2
−2
Conversation
ykzts
reviewed
Aug 1, 2017
| @@ -2,7 +2,7 @@ | |||
| "name": "Mastodon", | |||
| "description": "A GNU Social-compatible microblogging server", | |||
| "repository": "https://github.com/tootsuite/mastodon", | |||
| "logo": "https://github.com/tootsuite/mastodon/raw/master/app/javascript/images/logo.svg", | |||
This comment has been minimized.
This comment has been minimized.
ykzts
Aug 1, 2017
Author
Collaborator
The raw format of GitHub returns Content-type: text/plain. SVG will not be rendered unless Content-type is image/svg+xml when imported with img element.
I thought it would be better to use an avatar image with a permanently URL.
Gargron
approved these changes
Aug 1, 2017
Gargron
merged commit e05606c
into
tootsuite:master
Aug 1, 2017
ykzts
deleted the
ykzts:mastodon-logo
branch
Aug 1, 2017
pfigel
added a commit
to pfigel/mastodon
that referenced
this pull request
Aug 3, 2017
YaQ00
added a commit
to YaQ00/mastodon
that referenced
this pull request
Sep 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.


ykzts commentedAug 1, 2017