New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add media timeline #6631

Merged
merged 1 commit into from May 21, 2018

Conversation

7 participants
@ykzts
Collaborator

ykzts commented Mar 5, 2018

screenshots

Toots Media
Screenshot on Toots Screenshot on Media
@akihikodaki

This comment has been minimized.

Show comment
Hide comment
@akihikodaki

akihikodaki Mar 5, 2018

Collaborator

I am not a fan of this change because:

  • we already have several timelines: home, local, and federated. Why add even more?
  • the navigation bar has too many buttons. As it gets more items, it looks more messy and each buttons will be smaller and hard to tap on smartphone.
  • "media" timeline is confusing by nature. Does it list media in home, local, or federated?

The problems listed above may be resolved by adopting the UI similar to #6572.

Collaborator

akihikodaki commented Mar 5, 2018

I am not a fan of this change because:

  • we already have several timelines: home, local, and federated. Why add even more?
  • the navigation bar has too many buttons. As it gets more items, it looks more messy and each buttons will be smaller and hard to tap on smartphone.
  • "media" timeline is confusing by nature. Does it list media in home, local, or federated?

The problems listed above may be resolved by adopting the UI similar to #6572.

@ykzts

This comment has been minimized.

Show comment
Hide comment
@ykzts

ykzts Mar 5, 2018

Collaborator

demo

🤔

Collaborator

ykzts commented Mar 5, 2018

demo

🤔

@akihikodaki

This comment has been minimized.

Show comment
Hide comment
@akihikodaki

akihikodaki Mar 5, 2018

Collaborator

Well, the setting column requires extra steps to use the feature. It would be troublesome especially if a user wants to see both of federated timeline and media timeline since it requires to click more to switch them. So I'm also 🤔 .

By the way, the UI introduced by #6572, which I suggested earlier, does not have such a problem. I suspect you have a reason you still don't adopt #6572. The "only media" option in column setting and the media timeline is similar in terms that those preferences will be persistent when they are pinned. Is that what you intend? Or do you have reasons you prefer the media timeline or the "only media" option or ones you do not like #6572 for this purpose?

Collaborator

akihikodaki commented Mar 5, 2018

Well, the setting column requires extra steps to use the feature. It would be troublesome especially if a user wants to see both of federated timeline and media timeline since it requires to click more to switch them. So I'm also 🤔 .

By the way, the UI introduced by #6572, which I suggested earlier, does not have such a problem. I suspect you have a reason you still don't adopt #6572. The "only media" option in column setting and the media timeline is similar in terms that those preferences will be persistent when they are pinned. Is that what you intend? Or do you have reasons you prefer the media timeline or the "only media" option or ones you do not like #6572 for this purpose?

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Mar 8, 2018

Actually I like it, but I agree with @akihikodaki about the fact you have to click twice. This can be resolved with a toggle icon on the timelines titlebar (see images for an example).

Off (current situation):
media-timeline-off

On:
media-timeline-on

ghost commented Mar 8, 2018

Actually I like it, but I agree with @akihikodaki about the fact you have to click twice. This can be resolved with a toggle icon on the timelines titlebar (see images for an example).

Off (current situation):
media-timeline-off

On:
media-timeline-on

@akihikodaki

This comment has been minimized.

Show comment
Hide comment
@akihikodaki

akihikodaki Mar 11, 2018

Collaborator

I think it is better. It would be nicer if it is colored when it is on since a colored icon often carries semantic meaning to show it is enabled.

Collaborator

akihikodaki commented Mar 11, 2018

I think it is better. It would be nicer if it is colored when it is on since a colored icon often carries semantic meaning to show it is enabled.

@Gargron

This comment has been minimized.

Show comment
Hide comment
@Gargron

Gargron Apr 10, 2018

Member

By the way, the UI introduced by #6572, which I suggested earlier, does not have such a problem

I agree with Aki that the tabs might be a good fit for this.

Member

Gargron commented Apr 10, 2018

By the way, the UI introduced by #6572, which I suggested earlier, does not have such a problem

I agree with Aki that the tabs might be a good fit for this.

@ykzts ykzts added the ui label May 21, 2018

@ykzts

This comment has been minimized.

Show comment
Hide comment
@ykzts

ykzts May 21, 2018

Collaborator

@akihikodaki @jeroenpraat @Gargron I updated (See screenshot of description).

Collaborator

ykzts commented May 21, 2018

@akihikodaki @jeroenpraat @Gargron I updated (See screenshot of description).

@Gargron Gargron merged commit 7403e5d into tootsuite:master May 21, 2018

9 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check-i18n Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-webui Your tests passed on CircleCI!
Details
codeclimate All good!
Details

@ykzts ykzts deleted the ykzts:media-timeline branch May 21, 2018

SerCom-KC added a commit to SerCom-KC/mastodon that referenced this pull request May 21, 2018

Gargron added a commit that referenced this pull request May 21, 2018

i18n: Update Simplified Chinese translations (#7565)
* i18n: (zh-CN) #7532

* i18n: (zh-CN) #6984

* i18n: (zh-CN) #7391, #7507

* i18n: (zh-CN) #6998

* i18n: (zh-CN) #7074

* i18n: (zh-CN) #7000, #7032, #7131 (#7032, #7040)

* i18n: (zh-CN) #7130, #7188

* i18n: (zh-CN) #6486

* i18n: (zh-CN) #6292

* i18n: (zh-CN) #7347

* i18n: (zh-CN) #6661

* i18n: (zh-CN) #6425

* i18n: (zh-CN) #6597

* i18n: (zh-CN) #6695

* i18n: (zh-CN) #6325

* i18n: (zh-CN) #6460, #7375

* i18n: (zh-CN) #6872

* i18n: (zh-CN) #6818

* i18n: (zh-CN) #7452

* i18n: (zh-CN) #7176

* i18n: (zh-CN) #6460

* i18n: (zh-CN) #7213

* i18n: (zh-CN) #7376

* i18n: (zh-CN) #6556

* i18n: (zh-CN) #6645

* i18n: (zh-CN) #6448

* i18n: (zh-CN) #5303

* i18n: (zh-CN) #7445

* i18n: (zh-CN) Normalization and improvements

* i18n: (zh-CN) #7391

* i18n: (zh-CN) #6627

* i18n: (zh-CN) #6956, #7546

* i18n: (zh-CN) #6636

* i18n: (zh-CN) #6610, #6875

* i18n: (zh-CN) #6887

* i18n: (zh-CN) #4514

* i18n: (zh-CN) #6628

* i18n: (zh-CN) #6771

* i18n: (zh-CN) #6772

* i18n: (zh-CN) #7178

* i18n: (zh-CN) #7521

* i18n: (zh-CN) #6570

* i18n: (zh-CN) #6593

* i18n: (zh-CN) #6423

* i18n: (zh-CN) #6157

* i18n: (zh-CN) #7089

* i18n: (zh-CN) #6733

* i18n: (zh-CN) #7072

* i18n: (zh-CN) #6520

* i18n: (zh-CN) Improvment

* i18n: (zh-CN) #6631
@jebuskrust

This comment has been minimized.

Show comment
Hide comment
@jebuskrust

jebuskrust May 21, 2018

Greetings,

Although this is pretty neato... 👍
When the local / federated timelines are pinned, it doesnt filter the pinned timelines :(

jebuskrust commented May 21, 2018

Greetings,

Although this is pretty neato... 👍
When the local / federated timelines are pinned, it doesnt filter the pinned timelines :(

@trwnh

This comment has been minimized.

Show comment
Hide comment
@trwnh

trwnh May 21, 2018

Contributor

I have to say this change is a bit confusing and looks weird...

  • Tab titles are confusing ("Toots" includes media as well)
  • Only present in local/federated, not in home column
  • Imply the existence of sub-columns, which is a more complicated concept than "one column per view"

It would be much better to specify "only media" as an available option in all columns.

Contributor

trwnh commented May 21, 2018

I have to say this change is a bit confusing and looks weird...

  • Tab titles are confusing ("Toots" includes media as well)
  • Only present in local/federated, not in home column
  • Imply the existence of sub-columns, which is a more complicated concept than "one column per view"

It would be much better to specify "only media" as an available option in all columns.

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost May 21, 2018

I agree with both previous comments. I also think these tabs take to much space. I still advise to do it like the screenshots I provided or hide it in the column settings.

@Gargron Probably better to revert this PR and delay it to a .1 release.

ghost commented May 21, 2018

I agree with both previous comments. I also think these tabs take to much space. I still advise to do it like the screenshots I provided or hide it in the column settings.

@Gargron Probably better to revert this PR and delay it to a .1 release.

@Gargron

This comment has been minimized.

Show comment
Hide comment
@Gargron

Gargron May 21, 2018

Member

Okay, fair enough.

Member

Gargron commented May 21, 2018

Okay, fair enough.

@SerCom-KC

This comment has been minimized.

Show comment
Hide comment
@SerCom-KC

SerCom-KC May 22, 2018

Contributor

Still looks buggy to me after #7575...

Steps to reproduce:

  1. Pin local/federated timeline when the filter is "Toots"
  2. Click "Back" button on the rightmost column (so it goes back to "Getting started")
  3. Click "Media" on the pinned local/federated column
  4. Click "Back" button on the rightmost column again

After step 3, the media timeline is displayed on the rightmost column instead of the pinned one
and then after step 4 the browser navigates to the previous history page instead of letting that column goes back to "Getting started"

Contributor

SerCom-KC commented May 22, 2018

Still looks buggy to me after #7575...

Steps to reproduce:

  1. Pin local/federated timeline when the filter is "Toots"
  2. Click "Back" button on the rightmost column (so it goes back to "Getting started")
  3. Click "Media" on the pinned local/federated column
  4. Click "Back" button on the rightmost column again

After step 3, the media timeline is displayed on the rightmost column instead of the pinned one
and then after step 4 the browser navigates to the previous history page instead of letting that column goes back to "Getting started"

@renatolond

This comment has been minimized.

Show comment
Hide comment
@renatolond

renatolond May 23, 2018

Collaborator

Just some comments on rc5:
Some users were kinda confused about the change. Most of the comments were about the fact that if pinned, it didn't only change the current tab, but actually opened a new tab with the new config. Some were also confused by the extra information (considering that they did not wanted the media tab but still had to see the option the whole time)

Collaborator

renatolond commented May 23, 2018

Just some comments on rc5:
Some users were kinda confused about the change. Most of the comments were about the fact that if pinned, it didn't only change the current tab, but actually opened a new tab with the new config. Some were also confused by the extra information (considering that they did not wanted the media tab but still had to see the option the whole time)

@ykzts

This comment has been minimized.

Show comment
Hide comment
@ykzts
Collaborator

ykzts commented May 23, 2018

byronhulcher added a commit to byronhulcher/mastodon that referenced this pull request Aug 18, 2018

byronhulcher added a commit to byronhulcher/mastodon that referenced this pull request Aug 18, 2018

i18n: Update Simplified Chinese translations (#7565)
* i18n: (zh-CN) #7532

* i18n: (zh-CN) #6984

* i18n: (zh-CN) #7391, #7507

* i18n: (zh-CN) #6998

* i18n: (zh-CN) #7074

* i18n: (zh-CN) #7000, #7032, #7131 (#7032, #7040)

* i18n: (zh-CN) #7130, #7188

* i18n: (zh-CN) #6486

* i18n: (zh-CN) #6292

* i18n: (zh-CN) #7347

* i18n: (zh-CN) #6661

* i18n: (zh-CN) #6425

* i18n: (zh-CN) #6597

* i18n: (zh-CN) #6695

* i18n: (zh-CN) #6325

* i18n: (zh-CN) #6460, #7375

* i18n: (zh-CN) #6872

* i18n: (zh-CN) #6818

* i18n: (zh-CN) #7452

* i18n: (zh-CN) #7176

* i18n: (zh-CN) #6460

* i18n: (zh-CN) #7213

* i18n: (zh-CN) #7376

* i18n: (zh-CN) #6556

* i18n: (zh-CN) #6645

* i18n: (zh-CN) #6448

* i18n: (zh-CN) #5303

* i18n: (zh-CN) #7445

* i18n: (zh-CN) Normalization and improvements

* i18n: (zh-CN) #7391

* i18n: (zh-CN) #6627

* i18n: (zh-CN) #6956, #7546

* i18n: (zh-CN) #6636

* i18n: (zh-CN) #6610, #6875

* i18n: (zh-CN) #6887

* i18n: (zh-CN) #4514

* i18n: (zh-CN) #6628

* i18n: (zh-CN) #6771

* i18n: (zh-CN) #6772

* i18n: (zh-CN) #7178

* i18n: (zh-CN) #7521

* i18n: (zh-CN) #6570

* i18n: (zh-CN) #6593

* i18n: (zh-CN) #6423

* i18n: (zh-CN) #6157

* i18n: (zh-CN) #7089

* i18n: (zh-CN) #6733

* i18n: (zh-CN) #7072

* i18n: (zh-CN) #6520

* i18n: (zh-CN) Improvment

* i18n: (zh-CN) #6631
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment