Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd media timeline #6631
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
akihikodaki
Mar 5, 2018
Collaborator
I am not a fan of this change because:
- we already have several timelines: home, local, and federated. Why add even more?
- the navigation bar has too many buttons. As it gets more items, it looks more messy and each buttons will be smaller and hard to tap on smartphone.
- "media" timeline is confusing by nature. Does it list media in home, local, or federated?
The problems listed above may be resolved by adopting the UI similar to #6572.
|
I am not a fan of this change because:
The problems listed above may be resolved by adopting the UI similar to #6572. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
akihikodaki
Mar 5, 2018
Collaborator
Well, the setting column requires extra steps to use the feature. It would be troublesome especially if a user wants to see both of federated timeline and media timeline since it requires to click more to switch them. So I'm also
By the way, the UI introduced by #6572, which I suggested earlier, does not have such a problem. I suspect you have a reason you still don't adopt #6572. The "only media" option in column setting and the media timeline is similar in terms that those preferences will be persistent when they are pinned. Is that what you intend? Or do you have reasons you prefer the media timeline or the "only media" option or ones you do not like #6572 for this purpose?
|
Well, the setting column requires extra steps to use the feature. It would be troublesome especially if a user wants to see both of federated timeline and media timeline since it requires to click more to switch them. So I'm also By the way, the UI introduced by #6572, which I suggested earlier, does not have such a problem. I suspect you have a reason you still don't adopt #6572. The "only media" option in column setting and the media timeline is similar in terms that those preferences will be persistent when they are pinned. Is that what you intend? Or do you have reasons you prefer the media timeline or the "only media" option or ones you do not like #6572 for this purpose? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
ghost
Mar 8, 2018
Actually I like it, but I agree with @akihikodaki about the fact you have to click twice. This can be resolved with a toggle icon on the timelines titlebar (see images for an example).
ghost
commented
Mar 8, 2018
|
Actually I like it, but I agree with @akihikodaki about the fact you have to click twice. This can be resolved with a toggle icon on the timelines titlebar (see images for an example). |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
akihikodaki
Mar 11, 2018
Collaborator
I think it is better. It would be nicer if it is colored when it is on since a colored icon often carries semantic meaning to show it is enabled.
|
I think it is better. It would be nicer if it is colored when it is on since a colored icon often carries semantic meaning to show it is enabled. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Gargron
Apr 10, 2018
Member
By the way, the UI introduced by #6572, which I suggested earlier, does not have such a problem
I agree with Aki that the tabs might be a good fit for this.
I agree with Aki that the tabs might be a good fit for this. |
ykzts
added
the
ui
label
May 21, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
ykzts
May 21, 2018
Collaborator
@akihikodaki @jeroenpraat @Gargron I updated (See screenshot of description).
|
@akihikodaki @jeroenpraat @Gargron I updated (See screenshot of description). |
Gargron
merged commit 7403e5d
into
tootsuite:master
May 21, 2018
9 checks passed
ykzts
deleted the
ykzts:media-timeline
branch
May 21, 2018
added a commit
to SerCom-KC/mastodon
that referenced
this pull request
May 21, 2018
added a commit
that referenced
this pull request
May 21, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
jebuskrust
May 21, 2018
Greetings,
Although this is pretty neato...
When the local / federated timelines are pinned, it doesnt filter the pinned timelines :(
jebuskrust
commented
May 21, 2018
|
Greetings, Although this is pretty neato... |
This was referenced May 21, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
trwnh
May 21, 2018
Contributor
I have to say this change is a bit confusing and looks weird...
- Tab titles are confusing ("Toots" includes media as well)
- Only present in local/federated, not in home column
- Imply the existence of sub-columns, which is a more complicated concept than "one column per view"
It would be much better to specify "only media" as an available option in all columns.
|
I have to say this change is a bit confusing and looks weird...
It would be much better to specify "only media" as an available option in all columns. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
ghost
May 21, 2018
I agree with both previous comments. I also think these tabs take to much space. I still advise to do it like the screenshots I provided or hide it in the column settings.
@Gargron Probably better to revert this PR and delay it to a .1 release.
ghost
commented
May 21, 2018
|
I agree with both previous comments. I also think these tabs take to much space. I still advise to do it like the screenshots I provided or hide it in the column settings. @Gargron Probably better to revert this PR and delay it to a .1 release. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Okay, fair enough. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
SerCom-KC
May 22, 2018
Contributor
Still looks buggy to me after #7575...
Steps to reproduce:
- Pin local/federated timeline when the filter is "Toots"
- Click "Back" button on the rightmost column (so it goes back to "Getting started")
- Click "Media" on the pinned local/federated column
- Click "Back" button on the rightmost column again
After step 3, the media timeline is displayed on the rightmost column instead of the pinned one
and then after step 4 the browser navigates to the previous history page instead of letting that column goes back to "Getting started"
|
Still looks buggy to me after #7575... Steps to reproduce:
After step 3, the media timeline is displayed on the rightmost column instead of the pinned one |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
renatolond
May 23, 2018
Collaborator
Just some comments on rc5:
Some users were kinda confused about the change. Most of the comments were about the fact that if pinned, it didn't only change the current tab, but actually opened a new tab with the new config. Some were also confused by the extra information (considering that they did not wanted the media tab but still had to see the option the whole time)
|
Just some comments on rc5: |

Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.




ykzts commentedMar 5, 2018
•
edited
Edited 1 time
-
ykzts
edited May 21, 2018 (most recent)
screenshots