jrfnl
Follow
Create your own GitHub profile
Sign up for your own profile on GitHub, the best place to host code, manage projects, and build software alongside 50 million developers.
Sign up
Pinned
5,131 contributions in the last year
Contribution activity
July 2020
Created a pull request in Automattic/VIP-Coding-Standards that received 7 comments
Allow for checking test code coverage
As part of the sniff reviews, I'll be checking that the sniffs are properly covered by unit tests.
Adding a code coverage configuration and @covers …
+138
−7
•
7
comments
- Travis: change from "trusty" to "xenial"
- NewStripTagsAllowableTagsArray: use PHPCSUtils
- PHP 8.0: Handle removed `track_errors` and `$php_errormsg`
- PHP 8.0: RemovedFunctions: handle removal of 23 previously deprecated functions
- PHP 8.0: RemovedFunctionParameters: handle removed parameter x 3
- PHP 8.0: OptionalToRequiredFunctionParameters: add support for 3 changed functions
- PHP 8.0: NewInterfaces: add new Stringable interface to the sniff
- PHP 8.0: NewFunctions/Constants: account for new OpenSSL CMS support
- PHP 8.0: New `PHPCompatibility.ParameterValues.RemovedSplAutoloadRegisterThrowFalse` sniff
- PHP 8.0: RemovedCurlyBraceArrayAccess - handle removed support
- NewProcOpenCmdArray: improve efficiency
- NewPasswordAlgoConstantValues: cleaner error output
- NewNegativeStringOffset: cleaner error output
- NewIconvMbstringCharsetDefault: use PHPCSUtils
- Various sniffs: use Collections::functionDeclarationTokensBC()
- NewPackFormat: use PHPCSUtils
- NewFopenModes: cleaner error output
- NewArrayReduceInitialType: cleaner error output
- ForbiddenStripTagsSelfClosingXHTML: use PHPCSUtils
- ForbiddenGetClassNull: improve comment tolerance
- RemovedNamespacedAssert: bug fix - handling of nested function declarations / use PHPCSUtils
- RemovedMagicAutoload: use PHPCSUtils
- RemovedPHP4StyleConstructors: use PHPCSUtils
- PHP 8.0: NewMagicClassConstant: detect ::class on objects
- PHP 8.0: new `PHPCompatibility.FunctionDeclarations.RemovedOptionalBeforeRequiredParam` sniff
- Some pull requests not shown.
- Travis: change from "trusty" to "xenial"
- EscapeOutput: defensive coding
- ArrayIndentation: bug fix - prevent fixer conflict
- Move "minimum WP version" related utilities to dedicated `MinimumWPVersionTrait`
- PHP 8 | ControlStructureSpacing: bug fix - $data should be an array
- CI: use Parallel-Lint
- 3.0: ValidFunctionName: implement PHPCSUtils and more
- OperatorSpacing: defer to upstream for "instanceof"
- 3.0: CapitalPDangit: implement PHPCSUtils and check namespace names
- CastStructureSpacing: minor error message improvement
- Tests: move ruleset check file to tests directory
- 3.0: Remove some utility methods from the Sniff class
- PHPCS 4.x compatibility: allow for the JS/CSS tokenizer being dropped in PHPCS 4.x
- 3.0: Core ruleset: add PHPCSUtils requirement
- 3.0: Remove the PHPCSHelper class
- 3.0: Extra: replace the `Squiz.WhiteSpace.LanguageConstructSpacing` sniff
- 3.0: Core: replace `Generic.Arrays.DisallowShortArraySyntax` with `Universal` version
- 3.0: Replace the `WordPress.PHP.StrictComparisons` sniff
- .gitattributes: minor update
- RestrictedVariables: don't report on "use" in `isset()`
- RestrictedFunctions: fix false negative - functions in `config_settings` would never match
- PreGetPosts: improve the isEarlyMainQueryCheck() method
- Hooks/PreGetPosts: add support for hook-ins using short arrays
- Hooks/AlwaysReturnInFilter: add support for hook-ins using short arrays
- Functions/RestrictedFunctions: fix false positive on class instantiation
- Variables/RestrictedVariables: fix namespace of unit test file + fix test
- Test bootstrap: various minor tweaks
- Contributing: remove duplicate info
- Ruleset Tests: revert 485 and fix it
- RulesetTest: don't use the system default version of PHP
- DeclarationCompatibility: fix incorrect signature check for `Walker::walk()`
- WordPressVIPMinimum: fix the failing ruleset test & let Travis show failures
- RulesetTest: fix compatibility with Windows
- CS ruleset: minor tweaks
- Contributing: improve the text
- Travis: change from "trusty" to "xenial"
- Tokenizer/PHP: add some missing tokens to the $knownLengths property
- PHP 8.0 | Tokenizer/PHP: bug fix
- PHP 8.0 | Support union types in PHP Tokenizer and File class utility methods
- PHP 8.0 | Tokenizer/PHP: stabilize comment tokenization
- BackfillFnTokenTest: fix bug in the tests
- Travis: change from "trusty" to "xenial"
- PHP 8.0 | Tokenizer/PHP: add support for `static` return type to arrow functions
- PHP 8.0 | File::get[Method|Member][Parameters|Properties](): add unit test with "mixed" type
- PHPCS 3.x: test against nightly
- PHP 8.0 | Tokenizer/PHP: support PHP8 magic constant dereferencing
- PHP 8.0 | File::getMemberProperties(): support mixed type and union types
- PHP 8.0 | File::getMethodProperties(): support mixed type and union types
- PHP 8.0 | File::getMethodParameters(): support mixed type and union types
- Tests: stabilize an expected global
- Travis: require PHPUnit 9.3 for PHP 8
- Travis: run "nightly" only against PHPCS dev-master
- Travis: change from "trusty" to "xenial"
- BCTokens: add `magicConstants()` method
- Arrays::isShortArray(): update version numbers for upstream merge tokenizer fix
- Operators: new `isTypeUnion()` method
- PHP 8.0 | FunctionDeclarations::getParameters(): add support for constructor property promotion
- PHP 8.0 | Add support for union types
- FunctionDeclarations::isArrowFunction(): add test with PHP 8 "static" return type
- Arrays::isShortArray(): work round incorrect tokenization of PHP8 magic constant dereferencing
- UseStatements::getType(): work around a PHPCS 2.x issue
- Travis: test on nightly
- PHP 8.0: verified support for "mixed" type declarations
2
repositories not shown
Created an issue in Automattic/VIP-Coding-Standards that received 5 comments
Review all sniffs for compatibility with PHPCS >= 4.0
Development on PHPCS 4.x has started a while back. While there is no timeline known for when it will be ready/released, some (breaking) changes whi…
5
comments
- Review the `AbstractVariableRestrictionsSniff` class
- Check the hook callback parameter count ?
- Review use of external sniffs
- Review the WordPressVIPMinimum.Variables.VariableAnalysis sniff
- Review the WordPressVIPMinimum.Variables.ServerVariables sniff
- Review the WordPressVIPMinimum.Variables.RestrictedVariables sniff
- Review the WordPressVIPMinimum.UserExperience.AdminBarRemoval sniff
- Review the WordPressVIPMinimum.Security.Vuejs sniff
- Review the WordPressVIPMinimum.Security.Underscorejs sniff
- Review the WordPressVIPMinimum.Security.Twig sniff
- Review the WordPressVIPMinimum.Security.StaticStrreplace sniff
- Review the WordPressVIPMinimum.Security.ProperEscapingFunction sniff
- Review the WordPressVIPMinimum.Security.PHPFilterFunctions sniff
- Review the WordPressVIPMinimum.Security.Mustache sniff
- Review the WordPressVIPMinimum.Security.ExitAfterRedirect sniff
- Review the WordPressVIPMinimum.Security.EscapingVoidReturnFunctions sniff
- Review the WordPressVIPMinimum.Performance.WPQueryParams sniff
- Review the WordPressVIPMinimum.Performance.TaxonomyMetaInOptions sniff
- Review the WordPressVIPMinimum.Performance.RemoteRequestTimeout sniff
- Review the WordPressVIPMinimum.Performance.RegexpCompare sniff
- Review the WordPressVIPMinimum.Performance.OrderByRand sniff
- Review the WordPressVIPMinimum.Performance.NoPaging sniff
- Review the WordPressVIPMinimum.Performance.LowExpiryCacheTime sniff
- Review the WordPressVIPMinimum.Performance.FetchingRemoteData sniff
- Review the WordPressVIPMinimum.Performance.CacheValueOverride sniff
- Some issues not shown.
116
contributions
in private repositories
Jul 23 – Jul 29