The Wayback Machine - https://web.archive.org/web/20260225100109/https://github.com/github/codeql/pull/4157
Skip to content

Comments

Enable labeler action again#4157

Merged
RasmusWL merged 1 commit intogithub:mainfrom
RasmusWL:add-labeler-action
Sep 4, 2020
Merged

Enable labeler action again#4157
RasmusWL merged 1 commit intogithub:mainfrom
RasmusWL:add-labeler-action

Conversation

@RasmusWL
Copy link
Member

@RasmusWL RasmusWL commented Aug 28, 2020

This time using pull_request_target, so it will work properly with forks. See https://docs.github.com/en/actions/reference/events-that-trigger-workflows#pull_request_target

This reverts commit d5d6093.

Since the configuration file is already present on main, I think we should be able to tests this out before merging the PR. I'll at least give it a try 😊

I couldn't figure out how to test this without merging to main, but it should just work 🤞

This time using `pull_request_target`, so it will work properly with forks. See
https://docs.github.com/en/actions/reference/events-that-trigger-workflows#pull_request_target

This reverts commit d5d6093.
@RasmusWL RasmusWL marked this pull request as ready for review August 28, 2020 08:42
@RasmusWL RasmusWL requested review from p0 and tausbn September 2, 2020 11:42
@RasmusWL
Copy link
Member Author

RasmusWL commented Sep 2, 2020

@p0, @tausbn since you both expressed excitement for this, you get to be the reviewer for this one so it can be merged 🎉 please don't merge it though, I would like to do that myself so I can immediately check out if it works 😛

Copy link
Contributor

@tausbn tausbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@RasmusWL RasmusWL merged commit 2f48059 into github:main Sep 4, 2020
@RasmusWL RasmusWL deleted the add-labeler-action branch September 4, 2020 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants