The Wayback Machine - https://web.archive.org/web/20220423174300/https://github.com/nodejs/node/pull/34961
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove incorrect debug() in test-policy-integrity #34961

Merged
merged 1 commit into from Sep 2, 2020
Merged

test: remove incorrect debug() in test-policy-integrity #34961

merged 1 commit into from Sep 2, 2020

Conversation

Trott
Copy link
Member

@Trott Trott commented Aug 28, 2020

The instructions to use test:policy-integrity:NUMBER do not work, I'm
afraid. This removes them.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@Trott Trott requested a review from bmeck Aug 28, 2020
@nodejs-github-bot nodejs-github-bot added the test label Aug 28, 2020
@Trott
Copy link
Member Author

@Trott Trott commented Aug 28, 2020

/ping @bmeck, just in case I got it wrong here, but I don't think I did?
@Trott
Copy link
Member Author

@Trott Trott commented Aug 28, 2020

Pummel CI: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/16175/
@Trott Trott added the review wanted label Aug 30, 2020
@Trott
Copy link
Member Author

@Trott Trott commented Sep 1, 2020

@nodejs/collaborators This could use some reviews.
ryzokuken
ryzokuken approved these changes Sep 1, 2020
View changes
Copy link
Member

@ryzokuken ryzokuken left a comment

Thanks
@puzpuzpuz puzpuzpuz self-requested a review Sep 1, 2020
bmeck
bmeck approved these changes Sep 1, 2020
View changes
@Trott Trott added request-ci and removed review wanted labels Sep 1, 2020
@github-actions github-actions bot removed the request-ci label Sep 1, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@richardlau
Copy link
Member

@richardlau richardlau commented Sep 1, 2020

Commit subsystem should be "test" instead of "doc".
@Trott Trott changed the title doc: remove incorrect debug() in test-policy-integrity Sep 1, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Sep 1, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/32995/
@Trott
Copy link
Member Author

@Trott Trott commented Sep 2, 2020

Pummel CI: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/16218/
@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Sep 2, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/32999/
@Trott
test: remove incorrect debug() in test-policy-integrity
4f7440c 
The instructions to use `test:policy-integrity:NUMBER` do not work, I'm
afraid. This removes them.

PR-URL: nodejs#34961
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@Trott Trott merged commit 4f7440c into nodejs:master Sep 2, 2020
18 checks passed
@Trott
Copy link
Member Author

@Trott Trott commented Sep 2, 2020

Landed in 4f7440c
@Trott Trott deleted the policy-integrity branch Sep 2, 2020
richardlau pushed a commit that referenced this issue Sep 2, 2020
@Trott @richardlau
test: remove incorrect debug() in test-policy-integrity
12115e1 
The instructions to use `test:policy-integrity:NUMBER` do not work, I'm
afraid. This removes them.

PR-URL: #34961
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@richardlau richardlau mentioned this pull request Sep 2, 2020
Merged
4 tasks
richardlau pushed a commit that referenced this issue Sep 3, 2020
@Trott @richardlau
test: remove incorrect debug() in test-policy-integrity
b698d2e 
The instructions to use `test:policy-integrity:NUMBER` do not work, I'm
afraid. This removes them.

PR-URL: #34961
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
addaleax pushed a commit that referenced this issue Sep 22, 2020
@Trott @addaleax
test: remove incorrect debug() in test-policy-integrity
c2a3314 
The instructions to use `test:policy-integrity:NUMBER` do not work, I'm
afraid. This removes them.

PR-URL: #34961
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
addaleax pushed a commit that referenced this issue Sep 22, 2020
@Trott @addaleax
test: remove incorrect debug() in test-policy-integrity
0bd1768 
The instructions to use `test:policy-integrity:NUMBER` do not work, I'm
afraid. This removes them.

PR-URL: #34961
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Merged
joesepi pushed a commit to joesepi/node that referenced this issue Jan 8, 2021
@Trott @joesepi
test: remove incorrect debug() in test-policy-integrity
2ef967b 
The instructions to use `test:policy-integrity:NUMBER` do not work, I'm
afraid. This removes them.

PR-URL: nodejs#34961
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test
9 participants
@Trott @nodejs-github-bot @richardlau @bmeck @targos @ryzokuken @Himself65 @trivikr @puzpuzpuz