The Wayback Machine - https://web.archive.org/web/20201026232923/https://github.com/JohnSundell/Plot/pull/55
Skip to content

/ Plot

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make img tag supports width and height attribute #55

Merged
merged 1 commit into from Sep 11, 2020
Merged

Make img tag supports width and height attribute #55

merged 1 commit into from Sep 11, 2020

Conversation

@MainasuK
Copy link
Contributor

@MainasuK MainasuK commented Sep 8, 2020

<img> tag works with width and height attribute. And will set the image dimension in px. Make the ImageContext adopt HTMLDimensionContext so we could change the image size without CSS.

.img(
    .src("/images/sample.png"),
    .width(44),
    .height(44)
)
@MainasuK
feat: make img tag supports width and height attribute
Loading status checks…
be98ea5
@JohnSundell
JohnSundell approved these changes Sep 11, 2020
View changes
Copy link
Owner

@JohnSundell JohnSundell left a comment

Awesome, thanks a lot @MainasuK 👍
@JohnSundell JohnSundell merged commit 4d6eeb2 into JohnSundell:master Sep 11, 2020
2 checks passed
2 checks passed
ci/bitrise/b32a44b376d5f2ce/pr Passed - Plot-macOS
Details
ci/bitrise/d99f168e8ca5451d/pr Passed - Plot-Linux
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@MainasuK @JohnSundell
You can’t perform that action at this time.