Skip to content

feat: asyncio system tests #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Jul 29, 2020
Merged

feat: asyncio system tests #132

merged 18 commits into from
Jul 29, 2020

Conversation

rafilong
Copy link
Contributor

@rafilong rafilong commented Jul 28, 2020 •
edited
Loading

Added system tests and removed Watch from interface. Opened issue to re-add Watch support at a later date #131.

Additionally, made fixes to improperly mocked return types in AsyncClient.list_documents and AsyncQuery.stream.

This PR is stacked on #123.
@rafilong rafilong added this to the AsyncIO Client milestone Jul 28, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 28, 2020
rafilong
rafilong commented Jul 28, 2020
View reviewed changes
@rafilong rafilong force-pushed the asyncio-system-tests branch from d11d572 to 3cd740b Compare July 28, 2020 20:51
crwilcox
crwilcox suggested changes Jul 28, 2020
View reviewed changes
@rafilong rafilong requested a review from crwilcox July 28, 2020 21:38
BenWhitehead
BenWhitehead reviewed Jul 28, 2020
View reviewed changes
@rafilong rafilong mentioned this pull request Jul 28, 2020
Open
@rafilong rafilong requested a review from BenWhitehead July 29, 2020 17:35
@rafilong rafilong merged commit 4256a85 into googleapis:v2-staging Jul 29, 2020
@rafilong rafilong deleted the asyncio-system-tests branch July 29, 2020 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
3 participants
@rafilong @crwilcox @BenWhitehead