Enum Singleton implementation in Java

Question

I just wanted to implement the enum singleton in java. Here is my implementation where I have tried to create a singleton DataSource instance:

public enum EasySingleton {
    INSTANCE;

    private DataSource dataSource;

    private EasySingleton() {
        this.dataSource = MYDB.getDataSource();

    }

    public DataSource getDataSource(){
        return dataSource;
    }

}

and get this DataSource instance just like this:

DataSource dataSource = EasySingleton.INSTANCE.getDataSource();

I just wanted to confirm whether my implementation is correct or not. If it is wrong then please tell me how to implement the enum singleton to create a singleton DataSource instance.

I think this covers it pretty well already: codereview.stackexchange.com/questions/27296/… — Tunaki
– Tunaki, Commented Feb 17, 2016 at 19:23
Please include your MYDB class as well — at least the MYDB.getDataSource() function. — 200_success
– 200_success, Commented Feb 17, 2016 at 20:40

Pimgd · Accepted Answer · 2016-03-03 16:38:18Z

1

This is not a good use for a enum singleton. What you have there is a wrapper for MYDB.getDataSource(). You could handle that with a static synchronized method.

public class DataSourceAdapter {
    private static DataSource dataSource;
    public static synchronized DataSource getDataSource(){
        if(dataSource == null){
            dataSource = MYDB.getDataSource();
        }
        return dataSource;
    }
}

answered Mar 3, 2016 at 16:38

Pimgd

22.6k5 gold badges68 silver badges144 bronze badges

1

\$\begingroup\$ The difference between yours and @Rahul s solution is the execution time. I would prefer your solution:if anything goes wrong the stacktrace will include the reason of the instanciation. And application startup will be faster. \$\endgroup\$

slartidan
– slartidan

2016-03-03 16:52:25 +00:00
Commented Mar 3, 2016 at 16:52

Add a comment |

Stack Exchange Network

Enum Singleton implementation in Java

1 Answer 1

You must log in to answer this question.

Linked

Hot Network Questions

Enum Singleton implementation in Java

1 Answer 1

You must log in to answer this question.

Linked

Related

Hot Network Questions