11
votes
JavaFX app with User Authentication and SQL Persistence
superfluous comments
// region Main Methods
...
// endregion [Main Methods]
// region Utils
...
// endregion [private utility methods]
...
- 43.3k
8
votes
JavaFX app with User Authentication and SQL Persistence
Connection Management
None of the methods in the SQLUtils which creates a new Connection takes care about closing it, which is a ...
- 3,369
8
votes
Accepted
Implementing Dependency Injection into a JavaFX CRUD Application
Just a few stylistic comments. I'm not familiar with JavaFX so I can't really comment on how you have structured the application.
It is a common practise that package names match some domain name ...
- 9,388
8
votes
Accepted
Visualize Python data in JavaFX with Py4J
The while loop runs on the main thread, blocking any chance of clean interruption.
Run the start() loop in a background thread ...
- 141
7
votes
First Java Program: A Basic GUI Library Management System with JavaFX
Separations of Concerns
You've mixed UI with the business logic. The same components are responsible for interacting with the user and communicating with the database.
By doing so, you're violating ...
- 3,369
7
votes
Accepted
Alternate two messages on mouse click using Java-FX
In addition to coderodde's suggestion, you can apply DRY by moving the repeated pane.getChildren().clear() before the if ...
- 728
6
votes
Visualize Python data in JavaFX with Py4J
Here are some minor coding style suggestions for only the Python code.
Comments
Delete commented-out code to reduce clutter:
...
- 16.4k
5
votes
Accepted
JavaFX clone of Snake game
TL;DR summary: Use less comments, use meaningful comments, use Deque, DRY and generalise the repetitive code (with some smarts), out-of-border checking, make ...
- 216
5
votes
ConnectFourFX.java - A Java FX GUI app for playing Connect Four against AI
The functions has*Strike() are basically the same function, but with different starting points and different strides through the ...
- 88.7k
5
votes
First Java Program: A Basic GUI Library Management System with JavaFX
Alexander Ivanchenko treated the most points. That you were aware of the need of password hashing is clear, so okay.
In general I find the code advanced, assuming some non-java background, and ...
- 4,716
5
votes
First Java Program: A Basic GUI Library Management System with JavaFX
All of the Buttons go unused:
...
- 10.1k
5
votes
Alternate two messages on mouse click using Java-FX
You could simply do:
b = !b;
for a boolean b.
- 32.3k
5
votes
PathFinding.java: The grid view and model
Model
The main issue with this design is that the model doesn't get mutated through functions defined on it. You can get a cell and change it's contents, but the object instance that represents the ...
- 6,759
4
votes
Accepted
Snake Game in JavaFX
It looks good to me. I only have minor reviews.
All constants should be declared in a final variable.
...
- 116
4
votes
Accepted
Minesweeper JavaFX app
Thanks for sharing your code.
General coding
You declare member variables of the same type in one line. This is an unusual way to do it. It is certainly not a problem as long as you are the only one ...
- 7,291
4
votes
Cookie Clicker in JavaFX
I don't have the time to write a complete review but I do have possible (big) change you may want to consider. That is to see if you can use javaFX's Properties to store (and update) your numbers.
...
- 4,387
4
votes
Ensuring threads running infinite loops are terminated before exiting the program
Hello and welcome to code review! My main question is: How often do you write programs that have several threads running throughout the application lifecycle with identical exit condition? It is ...
- 9,388
4
votes
Accepted
JavaFX Connect Four AI
The Move class could have its getters removed by making use of final since its members row ...
- 16.6k
4
votes
Accepted
Space Invaders clone for a college project
Thanks for sharing your code.
Just a few things coming to my mind when skimming over it:
Inappropriate inheritance
In OOP we create subclasses to extend the behavior of a parent class. Your classes <...
- 7,291
4
votes
"2048" game in JavaFX
GameMatrix isn't easily constructible, as it enforces a singleton pattern. In my view, that's an antipattern, as it makes it impossible to run unit-tests in ...
- 88.7k
3
votes
Accepted
Snake Game in Java feedback
This is a very good for a few months of experience! You're on the right track with trying to separate concepts out into objects, but I think you made some strange decisions in your separating of ...
- 2,924
3
votes
Multiple buttons and their event handlers in JavaFX
First thing that comes to mind is subclassing Button, perhaps nesting it in your main class so it can easily modify class variables:
...
- 133
3
votes
Gem Puzzle game
You should avoid complex boolean expressions in if statements like you used here:
...
- 759
3
votes
Accepted
Media player component with JavaFX
I've never used fxml or jfoenix, so I may be missing some issues specific to those libraries, but I did notice a couple of points you could think about:
The logic in ...
- 196
3
votes
Simple Java game of a rocket ship flying in space
All constants should be declared in a final variable.
...
- 116
3
votes
Calculate the total sum of points that cost to level up a character
I'm not familiar with JavaFX so I'll focus on things not related to it.
One thing that I would not recommend is to mix two languages when naming function (or anything really) in your language. You ...
- 861
3
votes
Java Navigation System for GUI in JavaFX
No need to include class identifier
stage.setTitle(APPLICATION_TITLE);
Unhandled exception:
...
3
votes
Concerned about thread safety
Please take a look at this library for inspiration on how to state machine could be defined:
https://projects.spring.io/spring-statemachine/
Should I change locking system to "fair"? => ...
3
votes
Accepted
Create an analogue clock interface in Java using JavaFX
Whoever says your code is not following OOP principles should continue by explaining their opinion about the shortcomings. As I see, it's class room code and it's intention is to teach a certain thing ...
- 9,388
3
votes
Class for serializing themes for my JavaFX application
Here at Code Review we're not normally meant to simply suggest alternative solutions, but in this case, you already mentioned the alternative and I'm really just suggesting that you look again at your ...
- 863
Only top scored, non community-wiki answers of a minimum length are eligible