| Age | Commit message (Collapse) | Author | Files | Lines |
|
We already run iwyu(1) on a separate target (lint-c-iwyu).
Signed-off-by: Alejandro Colomar <alx@kernel.org>
|
|
Signed-off-by: Alejandro Colomar <alx@kernel.org>
|
|
It suggest 'cancellation' instead of 'cancelation', but we want the
latter. Since it hasn't caught anything useful, AFAIR, turn it off.
Signed-off-by: Alejandro Colomar <alx@kernel.org>
|
|
For example, in backtrace(3) we don't want to use 'static'.
Signed-off-by: Alejandro Colomar <alx@kernel.org>
|
|
It causes false positives:
CPPCHECK .tmp/man/man2/open_by_handle_at.2.d/t_name_to_handle_at.c.lint-c.cppcheck.touch
.tmp/man/man2/open_by_handle_at.2.d/t_name_to_handle_at.c:35:5: warning: inconclusive: If memory allocation fails, then there is a possible null pointer dereference: fhp [nullPointerOutOfMemory]
fhp->handle_bytes = 0;
^
.tmp/man/man2/open_by_handle_at.2.d/t_name_to_handle_at.c:26:17: note: Assuming allocation function fails
fhp = malloc(fhsize);
^
.tmp/man/man2/open_by_handle_at.2.d/t_name_to_handle_at.c:26:17: note: Assignment 'fhp=malloc(fhsize)', assigned value is 0
fhp = malloc(fhsize);
^
.tmp/man/man2/open_by_handle_at.2.d/t_name_to_handle_at.c:35:5: note: Null pointer dereference
fhp->handle_bytes = 0;
^
Signed-off-by: Alejandro Colomar <alx@kernel.org>
|
|
This diagnostic is useful for preventing unsafe macros, but other linter programs
provide a smaller rate of false positives, so let's turn this one off.
Signed-off-by: Alejandro Colomar <alx@kernel.org>
|
|
This diagnostic is too noisy, and isn't very useful. Turn it off.
Signed-off-by: Alejandro Colomar <alx@kernel.org>
|
|
We want to enable this warning again in the future, but for now it has
too many false positives.
Signed-off-by: Alejandro Colomar <alx@kernel.org>
|
|
-readability-avoid-nested-conditional-operator
Signed-off-by: Alejandro Colomar <alx@kernel.org>
|
|
Adding braces unnecessarily adds noise and thus hurts readability.
Ignore advice.
===
In src/bin/mansect line 23:
-e '(?s)^\.SH ('"$s"')$(?:(?!^\.(lf 1|TH|SH) ).)*';
^-- SC2250 (style): Prefer putting braces around variable references even when not strictly required.
===
Signed-off-by: Alejandro Colomar <alx@kernel.org>
|
|
This triggers false positives with trivial PCRE2 regexes.
===
In src/bin/mansect line 23:
-e '(?s)^\.SH ('"$s"')$(?:(?!^\.(lf 1|TH|SH) ).)*';
^----------------------------^ SC2016 (info): Expressions don't expand in single quotes, use double quotes for that.
===
Signed-off-by: Alejandro Colomar <alx@kernel.org>
|
|
We don't want to support arbitrary manual-page file names.
===
In src/bin/mansect line 17:
find -H "$@" -not -type d \
^-----------------------^ SC2038 (warning): Use -print0/-0 or -exec + to allow for non-alphanumeric filenames.
===
Signed-off-by: Alejandro Colomar <alx@kernel.org>
|
|
Signed-off-by: Alejandro Colomar <alx@kernel.org>
|
|
Signed-off-by: Alejandro Colomar <alx@kernel.org>
|
|
Signed-off-by: Alejandro Colomar <alx@kernel.org>
|
|
Signed-off-by: Alejandro Colomar <alx@kernel.org>
|
|
Signed-off-by: Alejandro Colomar <alx@kernel.org>
|
|
Signed-off-by: Alejandro Colomar <alx@kernel.org>
|
|
Signed-off-by: Alejandro Colomar <alx@kernel.org>
|
|
Signed-off-by: Alejandro Colomar <alx@kernel.org>
|
|
Signed-off-by: Alejandro Colomar <alx@kernel.org>
|
|
Signed-off-by: Alejandro Colomar <alx@kernel.org>
|
|
positives
Link: <https://lore.kernel.org/linux-man/e13c74fb-e17a-ba14-f1fc-9c75f05090db@kernel.org/T/#u>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
|
|
callbacks
Signed-off-by: Alejandro Colomar <alx@kernel.org>
|
|
Signed-off-by: Alejandro Colomar <alx@kernel.org>
|
|
We used it for transforming groff_man(7)'s CHECKSTYLE into errors, but
we already do that with grep(1). Moreover, the tmac was hiding
troff(1)'s warnings.
Signed-off-by: Alejandro Colomar <alx@kernel.org>
|
|
Signed-off-by: Alejandro Colomar <alx@kernel.org>
|
|
Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com>
|
|
Signed-off-by: Alex Colomar <alx.manpages@gmail.com>
|
|
-readability-identifier-length
Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com>
|
|
Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com>
|
|
Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com>
|
|
target to run checkpatch(1)
Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com>
|
|
to run cpplint(1)
Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com>
|
|
Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com>
|
|
Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com>
|
|
clang-tidy(1) to lint example programs
Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com>
|
|
Code examples contain many blank lines.
That warning, although sometimes valid, is too noisy.
Cc: "G. Branden Robinson" <g.branden.robinson@gmail.com>
Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com>
|
|
'lint' is a metatarget that triggers all lint-* targets (currently
that is just 'lint-groff').
'lint-groff' is a target that runs groff -rCHECKSTYLE to check
manual pages' groff(7) correctness.
etc/groff/tmac/deadly.tmac is a file written by Branden, to make
groff(1) abort when it finds a style problem, which then causes
make(1) to also abort.
CC: "G. Branden Robinson" <g.branden.robinson@gmail.com>
Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com>
|