Skip to content

Auto generate tracers #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Jul 6, 2016
Merged

Auto generate tracers #203

merged 21 commits into from
Jul 6, 2016

Conversation

nadr0
Copy link
Contributor

@nadr0 nadr0 commented Jul 5, 2016

finally got a working version with array1D/2D tracers.

When clicking generate at the top a new div pops up and you can create array 1d/2d tracers. The user can click inside each element in the matrix and edit it to any numeric value then press the generate JS and the code will appear in the tracer below. After this the user can copy and paste the code into the data.js file or the scratch pad.

what I like

  • I got to use similar code for 1d/2d array creation
  • a div overlay that just pops up for you can create these in any algorithm example and close it and it brings you back to the example

what I don't like

  • the visuals for the input fields and buttons
    • needs to look cleaner
  • createHTML() function in js/create/index.js (it works though)

todos:

  • add chart tracer
  • add graph tracer
Kevin Nadro added 21 commits June 27, 2016 19:10
Merge remote-tracking branch 'parkjs814/master' into sidebar-transition
8989291
sand box
c948a50
Merge remote-tracking branch 'parkjs814/master' into auto-generate-tr…
a82741a 
…acers
sandbox
f1bf5f5 
- replace the code with html for people can click buttons and fill out
fields! they won’t need to see any data/code.js files!
modules??
73f5da4
more!
bef9e8f 
figuring out how all of this stuff works, still very confused on where
to include javascript files and how to access the code through all the
modules
2dmatrix tracer created!
25c4cb4 
creates a 2dmatrix tracer with input values on it.
fixing positions of the modules when creating
e985152
generating code progress
a72443f
progress on generating javascript code
5463e43 
got the logger to print the javascript code now
more updates
ec6d55a 
- renaming of files
- highlighting of the text
- clear modules so it doesn’t make more than the 2
sandbox container show
7a55695 
a way to make sure the sandbox container shows up when inside the
sandbox tracers and when you aren’t in it
cleaning up code and files
34fb410 
- making more files and renaming things
fixing broken code
d8755f0 
- working prototype
- need to fix the vertical split bar to have the divider between
workspace and sandbox container work together
updated description
5d7d0d2
new window overlay for generating
4bf07b1 
- removed the sandbox tab its not an algorithm now
- the overlay can be opened by pressing “generate” button at the top
menu bar
- creates overlayed divs that have the functionality to generate a
tracer and the code
- (x) button to close and return to the algorithm
can't spam create the generate overlay
0ff9d86
fixed reloading of the algorithm
0dba50d 
- changed the save/load of the algorithm for it correctly returns to
the example after closing the generate overlay
working version..
f7bcdda 
everything should be fine
remove console log
fc2fbd0
fixed tracer naming
10f14a3
@nadr0 nadr0 mentioned this pull request Jul 5, 2016
Open
@64json 64json merged commit 0136803 into algorithm-visualizer:master Jul 6, 2016
@64json
Copy link
Member

64json commented Jul 6, 2016 •
edited
Loading

I have tested this on Chrome, Safari, and Firefox, but it doesn't work on any of those.
It is unable to change columns and rows, create matrices, or generate Javascript.
Could you check it again?
@nadr0
Copy link
Contributor Author

nadr0 commented Jul 6, 2016 •
edited
Loading

Interesting, its working for me on the website. Is there any console errors?

note: the change columns/rows isn't live reload, so you would have to click create matrices each time after changing the size and it would reset the values inside the matrix.

(another note: you have to be in the tracer view tab for it to show up, I probably should auto click that tab when clicking the "generate" button.)
@64json
Copy link
Member

64json commented Jul 6, 2016

I don't see any errors in console.

On Thu, Jul 7, 2016, 1:55 AM Kevin Nadro notifications@github.com wrote:

Interesting, its working for me on the website. Is there any console
errors?

—
You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub
https://github.com/parkjs814/AlgorithmVisualizer/pull/203#issuecomment-230835890,
or mute the thread
https://github.com/notifications/unsubscribe/ABizLPBqHRjEyj-g-bo2X6VL1G8EGy5jks5qS94RgaJpZM4JEuKd
.
@nadr0
Copy link
Contributor Author

nadr0 commented Jul 7, 2016

Since you merged it to master its up on the site, I don't see any issues with it. I have tried on my computer and several other and it works fine, I have been testing in Chrome. Maybe some screen shots or video of the issues you are having?
64json added a commit that referenced this pull request Jul 24, 2018
@64json
Merge pull request #203 from nadr0/auto-generate-tracers
704b54d 
Auto generate tracers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@nadr0 @64json