This repository was archived by the owner on Sep 8, 2020. It is now read-only.
Resetting Undo Manager after content is set to allow the same editor to be used for multiple data rows. #334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please squash these into one commit and I can work on getting these changes in. |
…. open row 1 to populate editor, close row 1, then open row 2 to populate the same editor), there is an issue where if you hit 'undo' while in row 2, it will start going back to the content from row 1. I would recommend adding in a line that will refresh the undoManager when the content is reset.
|
Should be good. |
|
It looks like travis says there is a test failing. Can you check on that? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the same tinymce editor for different rows of content (i.e. open row 1 to populate editor, close row 1, then open row 2 to populate the same editor), there is an issue where if you hit "undo" while in row 2, it will start going back to the content from row 1. I would recommend adding in a line that will refresh the undoManager when the content is re-set.