-
-
Notifications
You must be signed in to change notification settings - Fork 158
Release v5.0.0-rc.1 #224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Release v5.0.0-rc.1 #224
Conversation
<!-- Docsify v4 --> | ||
<script src="//cdn.jsdelivr.net/npm/docsify@4"></script> | ||
<!-- Docsify rc --> | ||
<script src="//cdn.jsdelivr.net/npm/docsify@rc"></script> | ||
_plugins_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we make an option -rc
for the rc
version adoption instead of replace it as rc
?
By default we should always build and fetch the standard version like @4
or @5
.
And we don't need remove the -rc
option when the v5
released also, cuz it will natural support new rc
versions in future.
Alternatively, should we expose another option as -v ? by default fetch the standard version. user can use it like -v 4.1
, -v 5
, -v rc
to replace the resources version of docsify.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, it is only an RC version. It will be switched when the official version of v5 is released.
Take --local
as an example. If you use the rc version of docsify-cli, it will also use rc resources.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand that. I meant that we don't need a cli for rc only, instead, we need cli to support rc version or switch different version resources.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to submit a PR. Similar to plugin selection, you only need to provide the version selection and replacement content.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should add-on this change directly or make another one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check out a new branch from the current branch.
Uh oh!
There was an error while loading. Please reload this page.