gh-53950: Clear MESSAGES in msgfmt
#133316
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What would be even better is not having a global variable at all, though that would be a larger change and is already partially covered by #10875 I believe. |
tomasr8
reviewed
May 2, 2025
|
We can just clear it for now, till the larger change is merged. |
tomasr8
approved these changes
May 2, 2025
|
Also request @serhiy-storchaka |
merwok
reviewed
May 2, 2025
|
I am unsure about the better fix here. Why not eliminate the global variable if that fixes the problem? Then it will make the other PR smaller. |
|
@merwok I updated the PR with that if that is what you prefer, it is not too bad, the diff is pretty low. |
|
Sharing MESSAGES between files is a (mis-)feature. See #10875 which solves this problem more thoroughly. |
tomasr8
reviewed
May 2, 2025
|
Do you mind splitting it from the larger pr, it would simplify it as Eric mentioned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @tomasr8 @merwok