Skip to content

Add Build and lint workflow #1101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 20, 2025
Merged

Add Build and lint workflow #1101

merged 2 commits into from
Apr 20, 2025

Conversation

StanFromIreland
Copy link

@StanFromIreland StanFromIreland commented Apr 19, 2025

Inspired by pl's lint-and-build.yml. Example run: https://github.com/python/python-docs-pl/actions/runs/14550280751 (less the Transifex parts)

Run of this workflow: https://github.com/StanFromIreland/python-docs-ko/actions/runs/14553083085

Note that there are issues in the older Docs (see run above) so it is up to you @flowdas as to what versions you wish to test.

@flowdas
Copy link
Collaborator

flowdas commented Apr 19, 2025

@corona10 @darjeeling

I see three main issues.
The easiest one is a linting issue, which can be fixed one by one.
The second is that blurb fails in older Docs, which seems to be a version issue of some sort.
The last one seems to be a TeX-related issue (but I'm not sure).

My opinion is to accept the PR.
Then let's fix them one by one.

Thanks @StanFromIreland

Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :)

In the future, we may be able to consider to adding preview link at the PR stage

@corona10
Copy link
Member

Delegate mering this PR to @flowdas

@StanFromIreland
Copy link
Author

@corona10 I’ll send a pr for that after this is merged :-)

@flowdas flowdas merged commit 3e1c915 into python:3.13 Apr 20, 2025
@StanFromIreland StanFromIreland deleted the 3.13-lint branch April 20, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants