-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Scaladoc: fixes and improvements to context bounds and extension methods #22156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scaladoc: fixes and improvements to context bounds and extension methods #22156
Conversation
67ee8ec
to
7540be2
Compare
The change works for me. |
@Florian3k , if you do not have more changes, maybe we could remove the draft status, what do you think? @mbovel please could you consider a review? Thanks! |
There's one more thing to fix. Changes in this PR uncovered some bugs in rendering of |
Co-authored-by: Florian3k <mfornal@virtuslab.com>
7540be2
to
86c6894
Compare
Note for @Florian3k, about my adjustments with this-types: |
The new changes work for me. |
Those new changes seem to be working fine. |
@@ -26,7 +26,7 @@ abstract class Documentation[T, A <: Int, B >: String, -X, +Y](c1: String, val c | |||
|
|||
sealed trait CaseImplementThis(id: Int) | |||
|
|||
case class IAmACaseClass(x: Documentation.this.T, id: Int) extends CaseImplementThis/*<-*/(id)/*->*/ | |||
case class IAmACaseClass(x: T, id: Int) extends CaseImplementThis(id) //expected: case class IAmACaseClass(x: Documentation.this.T, id: Int) extends CaseImplementThis |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've adjusted this test case to better reflect what is really going on here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Closes #21662
More specifically:
\:
and\\:
inextensionMethodSignatures.scala
, also see Question: desugaring of right associative extenstion methods #22170)><
inextensionMethodSignatures.scala
)Additionally fixed and improved simplifying of type lambdas (
TypesSupport.scala
)Removed
MemberInfo
andunwrapMemberInfo
, which were quite complicated, doing several things at the same time and causedparseMember
to have two sources of truth.