changing misleading language identifier #4283
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -8,8 +8,8 @@ The ``language`` type is a subset of the ``ChoiceType`` that allows the user | |||
| to select from a large list of languages. As an added bonus, the language names | |||
| are displayed in the language of the user. | |||
|
|
|||
| The "value" for each language is the *Unicode language identifier* | |||
| (e.g. ``fr`` or ``zh-Hant``). | |||
| The "value" for each language is the *Unicode language identifier* used in the *International Components for Unicode* | |||
There was a problem hiding this comment.
I think that we should add a link to the list of official language identifiers. Unfortunately, I couldn't find it in the ICU website.
There was a problem hiding this comment.
Is this link ok http://source.icu-project.org/repos/icu/icu/trunk/source/data/locales/ ?
There was a problem hiding this comment.
Thanks for the link. In my opinion is a bit "rough". I was thinking about something like:
| Code | Locale |
|---|---|
es_MX |
Spanish (Mexico) |
fr |
International French |
... |
|
zh_Hant |
Chinese (Traditional Han) |
There was a problem hiding this comment.
I was looking around for something like that too, but couldn't find it either. Maybe just a link to http://site.icu-project.org will do?
|
Closed for not contributing the way specified in the docs http://symfony.com/doc/current/contributing/documentation/overview.html |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes issue #4251
Typical language standards use dashes, but symfony uses underscores like defined in ICU. So the docs were misleading.