28
votes
Accepted
Code that handles n% of test cases but not all
If the code produces wrong answers for some test cases, then the author is aware that the code is not working correctly as intended, and the question is thus prima facie off-topic for Code Review.
...
- 146k
21
votes
Accepted
PSA: Excel going "Not Responding" isn't broken code
If you don't do VBA, you probably don't know this, but most VBA host applications are single-threaded, and when VBA code runs for a long time it's completely normal that the main window's caption says ...
- 75.6k
15
votes
Why was my edit to fix an answer rejected, even though it was approved by the author?
When you do a suggested edit, the only information besides the edit that is shown to reviewers is the edit reason. Yours was
Fixed the answer in regards to the question.
This does not indicate ...
- 22.4k
15
votes
Are questions with undiscovered bugs allowed?
For this particular case, it's a common beginner error, that wouldn't show up during runtime unless the out-of-bounds reads lead to a win because it happened to look like 4 in a row. I've had plenty ...
- 7,041
14
votes
Are questions with undiscovered bugs allowed?
If you ask yourself:
Can you play a game of connect four with their code?
And your answer is:
Yes, except in some special case - which someone may be unlikely to test.
Then no the question shouldn'...
PeilonrayzMod
- 44.6k
12
votes
Accepted
Reviewing non-working code when author thinks it's working?
If we take a look at https://codereview.stackexchange.com/help/on-topic we see
To the best of my knowledge, does the code work as intended? if the OP answered this for him/her-self with yes, then the ...
- 51k
12
votes
Why was my edit to fix an answer rejected, even though it was approved by the author?
First of all, your edit is totally legit (thank you!), and it should have been approved.
The edit was rejected because 2 of 2 reviewers voted so, and by the powers that be (the Stack Exchange ...
- 113k
10
votes
Are questions with undiscovered bugs allowed?
It is unreasonable to insist that code posted for review has no bugs.
It is reasonable to require that code posted for review has no known bugs.
The rule exists so that we can concentrate on ...
- 88.7k
9
votes
Are questions with undiscovered bugs allowed?
I just voted to Reopen. My reasoning:
As far as the poster knew at the time of posting, the code worked. The code works for most situations. Two people answered, so the poster can't fix the code ...
- 22.4k
9
votes
Reviewing non-working code when author thinks it's working?
Unfortunately, your question is based on a faulty premise. The code to be reviewed consists of a makeBst() function with one test case. That test case produces ...
- 146k
8
votes
Is code "working as intended" if significant portions are hardcoded?
That question sure looks like a "gimme teh codez" disguised as a request for a code review. I guess it's fair to ask "what qualifies as 'working' and who are you to judge my code if it ...
- 156
8
votes
Accepted
Is the Code Review SE the right site for checking if the code of my Arduino project minimizes the risk of overheating as much as possible?
To my eyes your question could only be off-topic for one rule.
To the best of my knowledge, does the code work as intended?
-- help center
And from your description your code seems to work as ...
PeilonrayzMod
- 44.6k
8
votes
Review one-by-one feature?
The short answer is, if you know that your code has deficiencies that need to be fixed, then it is not ready to be reviewed here.
In general, we expect questions to have no known bugs. It might be ...
- 146k
7
votes
"Count maximum number of thieves that can be caught" question should be reopened
The question says:
Out of 24 test-cases 18 passed, the rest got the wrong answer.
If the approach is wrong I would like to know the correct answer.
As per the Help Center rules, broken code is off-...
- 146k
7
votes
Accepted
Posting a question where part of the code contains a known bug
If I read your question and the help center correctly, the code has to work as intended. If the bug prevents that, it's out. If the bug is considered acceptable, there is no problem.
Should the bug ...
MastMod
- 13.9k
6
votes
Accepted
Would a question asking an unimplemented feature about a fully working script be on-topic here?
Improving Performance
But I haven't been able to accelerate the convergence of the series further, I have tried to make it converge faster
Improving the performance of code is on-topic. However, the ...
PeilonrayzMod
- 44.6k
5
votes
Is undefined behavior (for C/C++ code) off-topic here?
You are kind of missing the point that this whole site Code Review is about code reviews, which is a well-known term for peer review by other programmers. It is not about discussing language features ...
- 4,919
4
votes
Accepted
I try to refactor a working code and it's doesn't work. Would adding the failed attempt be on-topic?
Getting the original reviewed is on-topic. Asking why your attempt to refactor it is asking us to fix it and thus not on-topic. But you can absolutely include it as a 'this is what I've been thinking ...
MastMod
- 13.9k
4
votes
Is code "working as intended" if significant portions are hardcoded?
That's not working by any reasonable definition - changes to the input file would be expected to make different output.
One could claim that's actually what's intended, but then it's not a very useful ...
- 88.7k
4
votes
Accepted
Are "review and guide me" on topic?
To the best of my knowledge, does the code work as intended?
Code Review aims to help improve working code. If you are trying to figure out why your program crashes or produces a wrong result, ask on ...
PeilonrayzMod
- 44.6k
4
votes
Are questions with undiscovered bugs allowed?
In my opinion, it is irrelevant whether the code is bug free or not. I'd say that code will almost always have "yet another bug" even if we feel we've caught all of them.
Otherwise, we should define ...
- 3,540
3
votes
Is undefined behavior (for C/C++ code) off-topic here?
To me this is a rather clear case of authorship of code; the spirit of that rule is that you're supposed to come here with a piece of code you've written, to get feedback on any/all aspects. This ...
- 75.6k
3
votes
Accepted
Are translating questions on topic?
No, all the code has to work as intended. If a part of it doesn't work, then it's off-topic.
Related Questions
Questions about code translation
Project translation from Java to C#
Code typed in from ...
PeilonrayzMod
- 44.6k
2
votes
Is code "working as intended" if significant portions are hardcoded?
Let's assume that the question is On-Topic but not one that you believe is a good fit for The Community, you should Downvote the question.
The Community guides the ...
- 29.1k
1
vote
I try to refactor a working code and it's doesn't work. Would adding the failed attempt be on-topic?
We can't review the code that doesn't work. But it may be helpful to include something like that as an illustration of why you're not using that approach. That may avoid reviewers suggesting the ...
- 88.7k
1
vote
Is undefined behavior (for C/C++ code) off-topic here?
tl;dr
I find your question to potentially be off-topic for Authorship of Code, being obviously broken and 'lacking context'.
I don't see much of a link with our rational for AoC as you're not asking ...
PeilonrayzMod
- 44.6k
1
vote
Is undefined behavior (for C/C++ code) off-topic here?
The code in the question consists solely of a type definition, not even a variable declaration. Without executable code it is impossible to tell if there will be undefined behavior or not.
Because of ...
pacmaninbwMod
- 26.2k
Only top scored, non community-wiki answers of a minimum length are eligible