On Sat, Sep 14, 2013 at 1:39 AM, Nikita Popov <nikita.ppv@gmail.com> wrote:
> On Sat, Sep 14, 2013 at 1:27 AM, Christopher Jones <
> christopher.jones@oracle.com> wrote:
>
> >
> >
> > On 09/13/2013 10:42 AM, Nikita Popov wrote:
> >
> >> Commit: 96b1c2145c2cd5e616dea191648c2d**73af0239c9
> >> Author: Nikita Popov <nikic@php.net> Fri, 13 Sep 2013
> >> 18:45:02 +0200
> >> Parents: d2950ac2791cd03559a58e78f5cd62**6283b9ee4d
> >> Branches: master
> >>
> >> Link: http://git.php.net/?p=php-src.**git;a=commitdiff;h=**
> >> 96b1c2145c2cd5e616dea191648c2d**73af0239c9<
> http://git.php.net/?p=php-src.git;a=commitdiff;h=96b1c2145c2cd5e616dea191648c2d73af0239c9
> >
> >>
> >> Log:
> >> Provide more macros for handling of interned strings
> >>
> >> * str_erealloc behaves like erealloc for normal strings, but will
> >> use emalloc+memcpy for interned strings.
> >> * str_estrndup behaves like estrndup for normal strings, but will
> >> not copy interned strings.
> >> * str_strndup behaves like zend_strndup for normal strings, but
> >> will not copy interned strings.
> >> * str_efree_rel behaves like efree_rel for normal strings, but
> >> will not free interned strings.
> >> * str_hash will return INTERNED_HASH for interned strings and
> >> compute it using zend_hash_func for normal strings.
> >>
> >
> > Hi Nikita,
> >
> > Running g++ on ext/intl/intl_convertcpp.cpp is failing for me with gcc
> > 4.1.2 on
> > Oracle Linux 5.9 (equivalent to RHEL 5.9):
> >
> > /home/cjones/php-src/Zend/**zend_string.h: In function ‘char*
> > _str_erealloc(char*, size_t, size_t)’:
> > /home/cjones/php-src/Zend/**zend_string.h:77: error: invalid conversion
> > from ‘void*’ to ‘char*’
> > make: *** [ext/intl/intl_convertcpp.lo] Error 1
> >
> > Can you have a look at it?
> >
>
> Thanks for the notice, should be fixed now. I always forget that out header
> files are written in C++ and not in C.
>
> Nikita
>
Hi Nikita,
you never managed to document these either in UPGRADING.INTERNALS even
thought that you were asked about it.
could you please do it (and for your others similar changes too) before the
release?
it is almost useless to provide/extend better internal APIs if we don't
document them.
--
Ferenc Kovács
@Tyr43l - http://tyrael.hu