Re: com php-src: Improved the fix for bug #67072, thanks Nikita: ext/standard/tests/serialize/005.phpt ext/standard/tests/serialize/bug67072.phpt
ext/standard/var_unserializer.c ext/standard/var_unserializer.re

From: Date: Mon, 05 May 2014 20:06:52 +0000
Subject: Re: com php-src: Improved the fix for bug #67072, thanks Nikita: ext/standard/tests/serialize/005.phpt ext/standard/tests/serialize/bug67072.phpt
ext/standard/var_unserializer.c ext/standard/var_unserializer.re
References: 1  Groups: php.cvs 
Request: Send a blank email to php-cvs+get-78105@lists.php.net to get a copy of this message 
On Fri, Apr 18, 2014 at 3:13 PM, Anatol Belski <ab@php.net> wrote:

> Commit:    c2acdbdd3deb6787329bf0aca8ab0c04ace2a50c
> Author:    Anatol Belski <ab@php.net>         Fri, 18 Apr 2014 15:13:32
> +0200
> Parents:   6e1e98d7b833492594aea9cf416905b42f8ee0f4
> Branches:  PHP-5.4 PHP-5.5 PHP-5.6 master
>
> Link:
> http://git.php.net/?p=php-src.git;a=commitdiff;h=c2acdbdd3deb6787329bf0aca8ab0c04ace2a50c
>
> Log:
> Improved the fix for bug #67072, thanks Nikita
>
> Bugs:
> https://bugs.php.net/67072
>
> Changed paths:
>   M  ext/standard/tests/serialize/005.phpt
>   M  ext/standard/tests/serialize/bug67072.phpt
>   M  ext/standard/var_unserializer.c
>   M  ext/standard/var_unserializer.re
>
>
> --
> PHP CVS Mailing List (http://www.php.net/)
> To unsubscribe, visit: http://www.php.net/unsub.php
>

Just ran into an issue running Symfony unit tests with PHPUnit. The issue
is this piece of code:

            // We have to use this dirty trick instead of
ReflectionClass::newInstanceWithoutConstructor()
            // because of
https://github.com/sebastianbergmann/phpunit-mock-objects/issues/154
            $object = unserialize(
                sprintf('O:%d:"%s":0:{}', strlen($className), $className)
            );

This ends up using the O: serialization type on a Serializable class, thus
causing a warning. Not sure what we should do about this.

Nikita

Thread (2 messages)

  • Anatol Belski
    • Nikita PopovRe: com php-src: Improved the fix for bug #67072, thanksNikita: ext/standard/tests/serialize/005.phpt
      ext/standard/tests/serialize/bug67072.phptext/standard/var_unserializer.c ext/standard/var_unserializer.re
« previous php.cvs (#78105) next »