Re: adding GB18030 support for mbstring
hi,
Thanks for the patches :)
2010/2/1 KITAZAKI Shigeru <shigeru_kitazaki@cybozu.co.jp>:
> Thank you for your suggestion.
> Let me introduce some patches which we published. They might be useful on
> specific environments although they are not bugs.
> If I had better to report below issues as bugs, please tell me.
>
> * php_syslog.patch
> syslog() function cannot properly send UTF-8 strings to event log on
> Windows. This patch changes the internal API. We, however, must set
> UTF-8 on 'mbstring.internal_incoding'.
> In addition, this changes the severity of 'LOG_ERR' from eventlog's
> warning to eventlog's error.
It has to be optional. Maybe a mbstring.syslog* option to set a given
encoding for the syslog functions.
> * php_ldap.patch
> This changes the internal API to use Windows native LDAP API instead of
> OpenLDAP one. This is because OpenLDAP has dropped Windows support.
That's something I have done too but I don't think we can do it in a
minor version as it introduces some BC breaks. For example with SSL,
as far as I know it is not possible to use custom cerficates in custom
places (via openssl).
Where did you read that openldap stops to support windows? Last time I
checked I saw that they stoped (they never really did) to stupport
VC++ but they did support windows. Some openldap contributors even
provide windows builds as commercial packages.
Cheers,
--
Pierre
@pierrejoye | http://blog.thepimp.net | http://www.libgd.org
Thread (13 messages)