Re: Re: hex2bin: E_WARNING is too much for odd string?

From:	Nikita Popov	Date:	Sat, 29 Jun 2013 09:25:52 +0000
Subject:	Re: Re: hex2bin: E_WARNING is too much for odd string?
References:	1 2 3 4 5 6	Groups:	php.internals
Request:	Send a blank email to internals+get-68018@lists.php.net to get a copy of this message

On Sat, Jun 29, 2013 at 3:41 AM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:

> Hi Sherif,
>
> The problem is that current code 'returns false for invalid hex' while it
> 'returns false and E_WARNING for invalid length'.
>
> We may choose behavior for invalid inputs
>  - return false always
>  - return false and raise E_WARNING always
>

For the record, I'm okay with having E_WARNING in both cases.

Nikita


   

Thread (21 messages)

• Yasuo OhgakiWed, 26 Jun 2013 19:21:28 +0000
  • Yasuo OhgakiWed, 26 Jun 2013 19:23:29 +0000Re: hex2bin: E_WARNING is too much for odd string?
  • Nikita PopovWed, 26 Jun 2013 19:40:02 +0000
    • Yasuo OhgakiWed, 26 Jun 2013 20:59:05 +0000
  • Kalle Sommer NielsenWed, 26 Jun 2013 22:13:39 +0000
    • Yasuo OhgakiWed, 26 Jun 2013 22:24:11 +0000
    • Yasuo OhgakiWed, 26 Jun 2013 22:37:23 +0000
  • Yasuo OhgakiThu, 27 Jun 2013 01:05:34 +0000Re: hex2bin: E_WARNING is too much for odd string?
    • Sherif RamadanThu, 27 Jun 2013 01:33:44 +0000Re: Re: hex2bin: E_WARNING is too much for odd string?
      • Yasuo OhgakiThu, 27 Jun 2013 03:05:09 +0000
        • Tjerk MeestersThu, 27 Jun 2013 11:55:12 +0000
          • Yasuo OhgakiFri, 28 Jun 2013 01:27:53 +0000
            • Tjerk MeestersFri, 28 Jun 2013 02:05:21 +0000
              • Yasuo OhgakiFri, 28 Jun 2013 02:48:21 +0000
      • Leszek KrupińskiFri, 28 Jun 2013 09:21:04 +0000
        • Sherif RamadanFri, 28 Jun 2013 09:38:47 +0000
          • Yasuo OhgakiSat, 29 Jun 2013 01:41:10 +0000
            • Sherif RamadanSat, 29 Jun 2013 01:54:27 +0000
              • Yasuo OhgakiSat, 29 Jun 2013 02:18:19 +0000
              • Lester CaineSat, 29 Jun 2013 09:29:44 +0000
            • Nikita PopovSat, 29 Jun 2013 09:25:52 +0000