Re: Patch: Fixing some .phpt's that fail with Wincache

From: Date: Wed, 04 Dec 2013 20:26:59 +0000
Subject: Re: Patch: Fixing some .phpt's that fail with Wincache
References: 1  Groups: php.internals 
Request: Send a blank email to internals+get-70499@lists.php.net to get a copy of this message
On Mon, Nov 25, 2013 at 11:15 AM, Eric Stenson <ericsten@microsoft.com>wrote:

>  Internals folks:
>
>
>
> Attached is a patch that includes fixes to some .phpt files that are
> failing when Wincache is enabled.  The patch is against the PHP-5.6 branch.
>


I can't reproduce any of these test failures with wincacheu on 5.6, either
with opcache or with no code cache (either with PFTT or run-tests).

I am using 5.6 r1205a6c x64 with the wincache DLL you gave me, on Win7 x64.

This is the wincache snippet of the INI I am using:
wincache.enablecli=1
wincache.ocenabled=0
wincache.fcenabled=1
wincache.ucenabled=1
extension=php_wincache.dll
zend_extension=<path to opcache dll>


What configuration are you using to run these (Win version, php build, INI,
etc...) ?



>
>
> The failures occur because the tests are coded to expect specific resource
> IDs.  However, when Wincache is loaded, it takes a few resource objects
> "off-the-top".  This causes these tests to erroneously fail.
>
>
>
> There isn't a bug filed for these; I am starting work on the PHP-5.6/x64
> stuff, and wanted to get the pass rate to match the results when Wincache
> wasn't loaded.
>
>
>
> Please review & consider for inclusion in the PHP project.
>
>
>
> Thx!
>
>     --E.
>
>
>
>
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>


Thread (13 messages)

« previous php.internals (#70499) next »