Re: Re: imagecrop fix
On Sat, Dec 28, 2013 at 12:09 PM, Pierre Joye <pierre.php@gmail.com> wrote:
> On Sat, Dec 28, 2013 at 5:04 AM, Gmail <laruence@gmail.com> wrote:
>>
>>
>> Sent from my iPhone
>>
>>> On Dec 28, 2013, at 11:10 AM, Pierre Joye <pierre.php@gmail.com> wrote:
>>>
>>>> On Dec 28, 2013 5:47 AM, "Rasmus Lerdorf" <rasmus@lerdorf.com>
>>>> wrote:
>>>>
>>>>
>>>> And much of that code isn't in 5.3. ImageCrop() is new in 5.5, for
>>> example.
>>>
>>> Yes, but the commit changed other functions (news has to be updated
>>> accordingly). I won't be able to test or valid the patch before the 6th, so
>>> if anyone likes or has time to do it, go ahead.
>> No behavior changed, previously , these function will modify the parameter if the item in
>> it is not expected type, it should be fixed.
>
> Right but the news file and commit message was not correct. Both
> should reflect what is being fixed (useful info for distros too) :)
>
> Btw, have you read the reporter's comment as well as mines? It looks
> like this fix is incomplete.
Ah, right, the desc is long, I have troubles with reading long text.... :<
I will have a try to fix rests..
thanks
>
> Cheers,
> --
> Pierre
>
> @pierrejoye | http://www.libgd.org
--
惠新宸 laruence
Senior PHP Engineer
http://www.laruence.com
Thread (8 messages)