Re: Re: 5dee3c11 break

From:	Levi Morrison	Date:	Tue, 06 May 2014 13:11:06 +0000
Subject:	Re: Re: 5dee3c11 break
References:	1 2 3 4 5 6 7	Groups:	php.internals
Request:	Send a blank email to internals+get-73976@lists.php.net to get a copy of this message

On Tue, May 6, 2014 at 6:43 AM, Dmitry Stogov <dmitry@zend.com> wrote:

> zend_std_has_dimension() doesn't know what (check_empty == 2) means.
>
> check_empty == 0 - ISSET => we don't need to call offsetGet() and relay on
> offsetExists() return value.
> check_empty == 1 - ISEMPTY => we should call offsetGet() after
> offsetExists().
>
> NULL values should be handled by offsetExists().
>

I am a bit curious, isset checks that the variable exists and is not
null; empty checks that the variable exists and is not empty. Why does
one call offsetGet and not the other? Both look at the value.

Sorry if I missed that bit of conversation.


   

Thread (17 messages)

• Dmitry StogovTue, 06 May 2014 08:11:20 +0000
  • Tjerk Anne MeestersTue, 06 May 2014 10:31:40 +0000Re: 5dee3c11 break
    • Dmitry StogovTue, 06 May 2014 11:25:22 +0000
      • Tjerk Anne MeestersTue, 06 May 2014 11:29:57 +0000
        • Dmitry StogovTue, 06 May 2014 11:50:13 +0000
          • Tjerk Anne MeestersTue, 06 May 2014 12:36:33 +0000
            • Dmitry StogovTue, 06 May 2014 12:43:00 +0000
              • Levi MorrisonTue, 06 May 2014 13:11:06 +0000Re: Re: 5dee3c11 break
                • Dmitry StogovTue, 06 May 2014 14:46:42 +0000
                  • Dmitry StogovTue, 06 May 2014 14:48:41 +0000
                  • Levi MorrisonTue, 06 May 2014 14:50:51 +0000
                    • Dmitry StogovTue, 06 May 2014 14:57:38 +0000
              • Tjerk Anne MeestersTue, 06 May 2014 23:33:26 +0000
                • Levi MorrisonWed, 07 May 2014 05:30:02 +0000Re: Re: 5dee3c11 break
                  • Levi MorrisonWed, 07 May 2014 05:31:12 +0000
          • Tjerk Anne MeestersWed, 07 May 2014 04:31:48 +0000
            • Dmitry StogovFri, 16 May 2014 16:32:36 +0000