Re: [phpng] naming
On 7 May 2014, at 19:11, Rowan Collins <rowan.collins@gmail.com> wrote:
> Marc Bennewitz wrote (on 07/05/2014):
>> Hi,
>>
>> I would also prefer to name it was it represents. I mean a ZVAL represents a PHP typed
>> value and not a C typed one. So for example IS_LONG would be IS_INTEGER and IS_DOUBLE would become
>> IS_FLOAT.
>>
>> Marc
>
> Ooh, that reminds me of something I've been meaning to file a bug for, and maybe even
> attempt a patch, if I can understand where it comes from: the message shown *to the user* when an
> internal function is passed an invalid value uses "double" and "long" instead of
> "float" and "int".
>
> To somebody not familiar with C or similar languages, the message "some_function() expects
> parameter 1 to be long, string given" is somewhat cryptic to say the least, particularly
> because long is an adjective not a noun in standard English, so it could easily be misread as
> something like "parameter 1 is not long enough".
>
> Just a pet peeve...
…that’s probably from zend_parse_parameters, no?
--
Andrea Faulds
http://ajf.me/
Thread (11 messages)