Re: php interactive shell: save history on SIGINT exit

From:	Johannes Schlüter	Date:	Wed, 23 Jul 2014 12:38:24 +0000
Subject:	Re: php interactive shell: save history on SIGINT exit
References:	1 2 3	Groups:	php.internals
Request:	Send a blank email to internals+get-75954@lists.php.net to get a copy of this message

On Mon, 2014-07-21 at 18:17 +0400, Dmitry Saprykin wrote:
> changed "write_history" at the end to "append_history" after
> each cli_is_valid_code.
> Now it is -1 line, +1 line commit and completely looks like bug fix. )

Have you tested with libedit? - A quick grep on my system shows no
append_history() call, haven't checked further, though.

johannes




   

Thread (13 messages)

• Dmitry SaprykinMon, 21 Jul 2014 09:12:26 +0000
  • Yasuo OhgakiMon, 21 Jul 2014 09:23:58 +0000
    • Michael WallnerMon, 21 Jul 2014 09:46:04 +0000
      • Dmitry SaprykinMon, 21 Jul 2014 09:50:10 +0000
        • Pierre JoyeMon, 21 Jul 2014 10:52:19 +0000
          • Bob WeinandMon, 21 Jul 2014 12:34:29 +0000
          • Dmitry SaprykinMon, 21 Jul 2014 13:08:20 +0000
  • Johannes SchlüterMon, 21 Jul 2014 14:00:55 +0000
    • Dmitry SaprykinMon, 21 Jul 2014 14:17:18 +0000
      • Johannes SchlüterWed, 23 Jul 2014 12:38:24 +0000
        • Tjerk MeestersWed, 23 Jul 2014 12:54:38 +0000
        • Dmitry SaprykinWed, 23 Jul 2014 13:08:42 +0000
          • Johannes SchlüterThu, 24 Jul 2014 16:13:19 +0000