ASP.net MVC Checkbox Issue

Question

I am working on an ASP.net MVC project and I am using the CheckBoxFor helper method to provide the value for a boolean in my model like so:

@Html.CheckBoxFor(m => m.ShouldSaveSearch, new { id="ShouldSaveSearch"})

If the checkbox gets checked by the user, it works completely fine and when the model is received by the controller. The ShouldSaveSearch property will be set to true.

[HttpGet]
public ActionResult Search(int studentSearchId = -1)
{
    return View(new StudentSearchModel(studentSearchId));
}

[HttpPost]
public ActionResult Search(StudentSearchModel m)
{
    ViewBag.SearchResults = Hub.Web.Models.Student.StudentSearchModel.Search(m);
    Hub.Web.Models.Student.StudentSearchModel.Save(m);
    m.ShouldSaveSearch = false;
    m.ShouldShareSearch = false;
    m.SavedSearchName = "";
    m.SavedSearchDescription = "";

    return View(m);
}

I then set the ShouldSaveSearch property to false and then return the same view with the same model that was originally submitted.

However, when the view renders, the checkbox for this property remains checked. Is there something that I am missing that is preventing the checkbox from unchecking itself?

It looks like you are resetting the form and then re-displaying the view. A better practice (the post-redirect-get pattern) would be to RedirectToAction("Search")<--targeting the GET request for the view instead of the POST — Forty-Two, Commented Feb 28, 2013 at 21:14
You don't need the id = "ShouldSaveSearch" - that would be generated by mvc itself. Second, where is the [HttpPost] attribute? — codingbiz, Commented Feb 28, 2013 at 21:14

Dave Alperovich · Accepted Answer · 2013-02-28 21:29:42Z

2

You seem to want to default the checkbox to unchecked. That is Not linked to the true/false value of lambda but the value of checked attribute

@Html.CheckBoxFor(m => m.ShouldSaveSearch, new { @checked="false"})

The other's points are equally important. Clear the ModelState!

edited Feb 28, 2013 at 21:29

answered Feb 28, 2013 at 21:21

Dave Alperovich

32.5k8 gold badges82 silver badges101 bronze badges

Add a comment |

Community · Accepted Answer · 2017-05-23 11:57:40Z

1

It sounds like the ModelState problem discussed in this question and also here

In a few words the HtmlHelper displays ModelState value not Model. See question for more details.

Possible options:

Implement the post-redirect-get pattern as suggested by Forty-Two
Reset the checkbox value using the ModelState collection, something like ModelState["ShouldSaveSearch"].Value = false

edited May 23, 2017 at 11:57

CommunityBot

11 silver badge

answered Feb 28, 2013 at 21:20

Ulises

13.4k5 gold badges36 silver badges52 bronze badges

This was indeed my problem, however, clearing the ModelState would remove other values from it that I do not want to be removed, and attempting the ModelState["ShouldSaveSearch"].Value = false solution returns an error "Cannot implicitly convert type 'bool' to 'System.Web.Mvc.ValueProviderResult'".
– bjonnn
Commented Feb 28, 2013 at 21:31
I was able to remove the one value by ModelState["ShouldSaveSearch"].Value = new ValueProviderResult("", "", CultureInfo.CurrentCulture);.
– bjonnn
Commented Feb 28, 2013 at 21:34
As a further update, I was able to simplify it by saying m.ShouldSaveSearch = false; and then ModelState.Remove("ShouldSaveSearch");
– bjonnn
Commented Mar 5, 2013 at 14:58

Add a comment |

Huske · Accepted Answer · 2013-02-28 21:25:04Z

The problem here is that if you return the same view to which you posted with the model data, MVC will think that you are returning because of an error. This is a normal behavior. If you want to redisplay the view then you should implement PRG pattern (Post-Redirect-Get). You issue will be always there regardless of whether ModelState.IsValid is true or false. You should redirect to the HttpGet version of your view, passing the parameter, and loading the data. If you want to avoid loading, store the data in TempData or some other Session implementation.

UPDATE: You are calling the version of an action that receives model object. Once you persist data call

return RedirectToAction("Search", new {studentSearchId = your_value});

Collectives™ on Stack Overflow

ASP.net MVC Checkbox Issue

3 Answers 3

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Linked

Related