Using insert query in python for postgresql

Question

I want to insert values to a database using python, but it's failed. This is my code:

 try:
     cur.execute("""INSERT INTO tb_distance (objek1, objek2, distance) VALUES ('%s','%s','%d')""", (data[i].jenis, data[k].jenis, distance))
     conn.commit()
 except:
     conn.rollback()
     print 'cannot insert into database'

Leistungsabfall · Accepted Answer · 2015-12-16 15:13:44Z

1

Thank you, I fixed my problem, I replace (,) to (%) before list of values. This is my code and run well:

cur.execute("""INSERT INTO tb_distance (objek1, objek2, distance) VALUES ('%s','%s','%f')""" % (data[i].jenis, data[k].jenis, distance))

edited Dec 16, 2015 at 15:13

Leistungsabfall

6,4887 gold badges38 silver badges44 bronze badges

answered Dec 16, 2015 at 6:09

Erna Piantari

6373 gold badges12 silver badges27 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Kenly Over a year ago

+1 for answering your question. What you have done is correct but not secure, dont format values in python code use instead this:

cur.execute("""INSERT INTO tb_distance (objek1, objek2, distance) VALUES (%(objek1)s , %(objek2)s ,%(distance)s);""", {"objek1": data[i].jenis, "objek2": data[k].jenis, "distance": distance})

falsetru · Accepted Answer · 2015-12-16 05:47:07Z

0

Remove quotes around the placeholders ('%s' -> %s, '%d' -> %d):

cur.execute(
    "INSERT INTO tb_distance (objek1, objek2, distance) VALUES (%s, %s, %d)",
    (data[i].jenis, data[k].jenis, distance)
)

answered Dec 16, 2015 at 5:47

falsetru

371k69 gold badges769 silver badges659 bronze badges

Collectives™ on Stack Overflow

Using insert query in python for postgresql

2 Answers 2

1 Comment

Comments

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Related