Javascript sort array on property array

Question

So I have this array of users that looks something like this:

[{
    userName: 'Jim',
    roles: ['Member']
}, {
    userName: 'Adam',
    roles: ['Administrator']
}, {
    userName: 'Suzy',
    roles: ['SuperUser']
}, {
    userName: 'Greg',
    roles: ['SuperUser']
}, {
    userName: 'Ady',
    roles: ['Administrator']
}, {
    userName: 'Jeremy',
    roles: ['Administrator']
}]

I would like to sort this array by it's roles. I tried doing this:

items.sort(function (a, b) {
    var aValue = a.roles[0];
    var bValue = b.roles[0];

    if (aValue < bValue) return -1;
    if (aValue > bValue) return -1;
    return 0;
});

But it doesn't do what I expect. Does anyone know how to solve this issue?

You're returning -1 for two comparison cases. One should return 1, depending on your sort order (ascending or descending) — nem035
– nem035, Commented Jun 8, 2017 at 17:16

Nenad Vracar · Accepted Answer · 2017-06-08 17:18:33Z

1

You can use localeCompare method for string comparison inside sort().

var data = [{"userName":"Jim","roles":["Member"]},{"userName":"Adam","roles":["Administrator"]},{"userName":"Suzy","roles":["SuperUser"]},{"userName":"Greg","roles":["SuperUser"]},{"userName":"Ady","roles":["Administrator"]},{"userName":"Jeremy","roles":["Administrator"]}]

data.sort(function(a, b) {
  return a.roles[0].localeCompare(b.roles[0])
})

console.log(data)

answered Jun 8, 2017 at 17:18

Nenad Vracar

122k16 gold badges160 silver badges184 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Charles L. · Accepted Answer · 2017-06-08 17:17:36Z

0

give this a shot

function SortByRole(a, b){
  var aRole = a.roles[0];
  var bRole = b.roles[0]; 
  return ((aRole < bRole) ? -1 : ((aRole > bRole) ? 1 : 0));
}

array.sort(SortByRole);

answered Jun 8, 2017 at 17:17

Charles L.

1,9802 gold badges39 silver badges61 bronze badges

Collectives™ on Stack Overflow

Javascript sort array on property array

2 Answers 2

Comments

Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Linked

Related