diff options
| author | Emil Velikov <emil.l.velikov@gmail.com> | 2024-09-22 16:21:44 +0100 |
|---|---|---|
| committer | Mario Limonciello <superm1@gmail.com> | 2024-10-10 14:33:32 +0000 |
| commit | ee8c336ab3ab434908866c9a5e6dbbc555a80f39 (patch) | |
| tree | 41839fd454d9f650002ef758eb013cf0f974ffad /check_whence.py | |
| parent | cc4c1fccb0d8f5ac675e16d89a1ab756da671961 (diff) | |
copy-firmware.sh: flesh out and fix dedup-firmware.sh
Flesh out the de-duplication logic in separate script. The copy-firmware.sh is
already complex enough and de-duplication doesn't really fit in there.
In the process we migrate away from the open-coded `ln --relative`. We also
avoid touching symlinks, which are not created by rdfind. Otherwise we end up
"fixing" the folder to folder symlinks (created earlier in the process) and
things explode.
As result we also get a few bonuses:
- the COPYOPTS shell injection is gone - the variable was never used
- people can dedup as separate step if/when they choose to do so
Aside: based on the noise in git log and around distros ... I'm wondering if
having the de-duplication as opt-in, would have been better. Is it too late to
change or the ship has sailed?
Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Diffstat (limited to 'check_whence.py')
| -rwxr-xr-x | check_whence.py | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/check_whence.py b/check_whence.py index afe97a76..09dbdd54 100755 --- a/check_whence.py +++ b/check_whence.py @@ -91,6 +91,7 @@ def main(): "contrib/templates/debian.copyright", "contrib/templates/rpm.spec", "copy-firmware.sh", + "dedup-firmware.sh", ] ) known_prefixes = set(name for name in whence_list if name.endswith("/")) |