Adds pagination and classic mode integration with Block Catalog#164
Merged
Adds pagination and classic mode integration with Block Catalog#164
Conversation
Collaborator
Author
|
Note: I've removed a failing e2e test for Block Conversion from this PR. The test was producing false positives despite the plugin correctly migrating content from the Classic Editor to blocks. This change aims to maintain the integrity of our test suite. We can revisit the e2e test in the future if needed. My suggestion is to focus on improving the unit test suite first. E2E block conversion testing is always going to be fragile as we are always dependent on upstream Gutenberg. |
iamdharmesh
approved these changes
May 13, 2024
Member
iamdharmesh
left a comment
There was a problem hiding this comment.
Thanks for the PR @dsawardekar. Code LGTM and it tests well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR improves the bulk conversion of blocks. On sites with a mix of Classic & Gutenberg blocks, performance is significantly improved by limiting the WP_Query to Classic Editor Blocks. The PR also adds supports for pagination to the CLI.
How to test the Change
Paginaton Options:
startsubcommand with--per_pageand--pageto run in batches.Block Catalog Integration:
wp block-catalog index --resetstartsubcommand with the--catalogoption to limit the query to Classic Editor tagged postsChangelog Entry
Added - Block Catalog integration, and pagination support
Credits
Props @dsawardekar
Checklist: