Merged
Conversation
jeffpaul
requested review from
a team and
faisal-alvi
and removed request for
a team and
jeffpaul
faisal-alvi
previously approved these changes
Oct 10, 2022
Contributor
Member
|
Noting that if anyone is able to help with the test failures here that would help move this PR along, thanks! |
added 7 commits
January 5, 2023 09:18
…nto add/73-bump-up-wp-php-minimums
|
@jeffpaul I have resolved the merge conflicts and updated code to ensure the tests doesn't fail due to the update in PHP version. Also, to mention that the PHPCS tests are failing due to a known bug (WordPress/WordPress-Coding-Standards#2035) in WPCS. So, I have added a temporary work around to that until they release a new version of WPCS. |
faisal-alvi
approved these changes
Jan 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
Bumped up WordPress PHP minimums.
Closes #73
Changelog Entry
Added - Bumped up WordPress and PHP Minimum Requirements
Credits
Props @jeffpaul @zamanq
Checklist: