Skip to content

Small question about camera model (multi focal length) #53

Description

@oUp2Uo

Hi, thanks for the great support for multi focal length, it works fine.
And I have some small questions about camera model part.

  1. Why does model simple-radial set default value K1=0.1?
    Meanwhile, model opencv sets default value K1=K2=0.
    https://github.com/3DOM-FBK/deep-image-matching/blob/master/src/deep_image_matching/io/h5_to_db.py#L159

  2. Manually editing cameras.yaml makes users can set everything, but it is not a easy usage when calculating large image set (>hundreds).
    Now I have written a small program to scan the file names in a folder.
    So my actually process is: 1. Put different focal length images in seperated sub-folders. 2. Run the scan program to get the file names in every sub-folders. 3. Move all the images in sub-folders to the images folder. 4. Edit cameras.yaml to fill in the file names.
    If ImageMatching class could scan sub-folders, it will be no need to do these steps. This makes all the images use a same camera model, which is not so flexible, but we can change it using COLMAP UI later.
    Of course, this is not a functional question, just for easy using for large data set.

Thank you.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions