Skip to content

DCP: backlight/parser fixes#106

Closed
jannau wants to merge 4 commits into
AsahiLinux:bits/200-dcpfrom
jannau:bits/200-dcp
Closed

DCP: backlight/parser fixes#106
jannau wants to merge 4 commits into
AsahiLinux:bits/200-dcpfrom
jannau:bits/200-dcp

Conversation

@jannau

@jannau jannau commented Jan 22, 2023

Copy link
Copy Markdown
Member
  • avoid race between mode set and systemd-backlight restore on startup
  • use backlight_get_brightness instead of accessing backlight properties
@marcan marcan force-pushed the bits/200-dcp branch 2 times, most recently from 10247ce to 81de906 Compare March 5, 2023 15:35
jannau and others added 4 commits March 11, 2023 12:16
@jannau
drm/apple: Use backlight_get_brightness()
8687850 
Backlight drivers are expected to use this instead of accessing
backlight properties.

Signed-off-by: Janne Grunau <j@jannau.net>
@jannau
drm/apple: Set backlight level indirectly if no mode is set
204e159 
Fixes following warning when systemd-backlight restores the backlight
level on boot before a mode is set:

Call trace:
  drm_atomic_helper_crtc_duplicate_state+0x58/0x74
  drm_atomic_get_crtc_state+0x84/0x120
  dcp_set_brightness+0xd8/0x21c [apple_dcp]
  backlight_device_set_brightness+0x78/0x130
  ...

Signed-off-by: Janne Grunau <j@jannau.net>
@hoshinolina @jannau
drm/apple: Fix bad error return
d550693 
Signed-off-by: Asahi Lina <lina@asahilina.net>
@hoshinolina @jannau
drm/apple: Fix parse_string() memory leaks
fba0932 
Signed-off-by: Asahi Lina <lina@asahilina.net>
@jannau jannau changed the title DCP: small backlight update Mar 11, 2023
@marcan

marcan commented Mar 11, 2023

Copy link
Copy Markdown

Manually merged, thanks!
@marcan marcan closed this Mar 11, 2023
marcan pushed a commit that referenced this pull request Apr 24, 2023
@svenpeter42 @marcan
Bluetooth: Add quirk to disable extended scanning
ca67d67 
Broadcom 4377 controllers found in Apple x86 Macs with the T2 chip
claim to support extended scanning when querying supported states,

< HCI Command: LE Read Supported St.. (0x08|0x001c) plen 0  #27 [hci0] 2.971839
> HCI Event: Command Complete (0x0e) plen 12                #28 [hci0] 2.972730
      LE Read Supported States (0x08|0x001c) ncmd 1
        Status: Success (0x00)
        States: 0x000003ffffffffff
[...]
          LE Set Extended Scan Parameters (Octet 37 - Bit 5)
          LE Set Extended Scan Enable (Octet 37 - Bit 6)
[...]

, but then fail to actually implement the extended scanning:

< HCI Command: LE Set Extended Sca.. (0x08|0x0041) plen 8  #105 [hci0] 5.460776
        Own address type: Random (0x01)
        Filter policy: Accept all advertisement (0x00)
        PHYs: 0x01
        Entry 0: LE 1M
          Type: Active (0x01)
          Interval: 11.250 msec (0x0012)
          Window: 11.250 msec (0x0012)
> HCI Event: Command Complete (0x0e) plen 4                #106 [hci0] 5.461777
      LE Set Extended Scan Parameters (0x08|0x0041) ncmd 1
        Status: Unknown HCI Command (0x01)

Signed-off-by: Sven Peter <sven@svenpeter.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@jannau @marcan @hoshinolina