Conversation
anson627
approved these changes
Feb 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a comprehensive end-to-end (E2E) testing framework for the AKS Flex Node project. It adds infrastructure-as-code for test environments, a reusable bash test orchestrator, Makefile targets for E2E workflows, and a GitHub Actions workflow for automated E2E testing. These changes enable automated validation of both authentication modes (MSI and bootstrap token) in CI and provide tools for local development and debugging of the E2E process.
E2E Testing Infrastructure and Workflow:
hack/e2e/infra/main.bicep) that provisions an AKS cluster and two Ubuntu VMs—one with managed identity (MSI) and one with bootstrap token auth—for E2E testing scenarios. The template outputs resource details for downstream automation..github/workflows/e2e-tests.yml) to automate E2E tests on PRs and tagged pushes, including resource provisioning, test execution, log collection, and cleanup, with support for skipping cleanup for debugging.Developer and CI Tooling:
e2e,e2e-infra,e2e-cleanup) to simplify running E2E tests and managing test infrastructure locally; updated the help target to document these. [1] [2]hack/e2e/README.mdwith setup instructions, command reference, environment variables, troubleshooting, and project layout to help developers run and debug E2E tests locally.Test Orchestration and Cleanup:
hack/e2e/lib/cleanup.sh, providing robust log collection from both VMs and the cluster, as well as a cleanup routine for Azure resources, supporting both manual and automated E2E runs.