feat: migrate systemd resolve settings to os configure component#114
Merged
feat: migrate systemd resolve settings to os configure component#114
Conversation
bcho
commented
Mar 5, 2026
| arc.NewInstaller(b.logger), // Setup Arc | ||
|
|
||
| configureSystem.Executor("configure-os", b.componentsAPIConn), | ||
| system_configuration.NewInstaller(b.logger), // Configure system (early) |
Member
Author
There was a problem hiding this comment.
fyi giving we have the resolve config implemented in component api side, we can remove this system_configuration now
anson627
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant improvements to DNS configuration for Kubernetes nodes, particularly ensuring that pods and kubelet use upstream DNS servers directly by bypassing the systemd-resolved stub resolver cache. It also refactors and simplifies the codebase by removing the now-redundant
system_configurationcomponent, and enhances the QEMU VM management script for better cross-platform networking support (macOS and Linux).DNS configuration improvements:
resolv-uplink-override.service) that symlinks/etc/resolv.confto/run/systemd/resolve/resolv.conf, ensuring kubelet and pods bypass the systemd-resolved cache and use upstream DNS directly. This is now managed via theconfigureBaseOSActionand is enabled as part of the base OS configuration. [1] [2] [3] [4]Codebase refactoring and cleanup:
system_configurationpackage, including its installer and constants, and updated the bootstrapper to no longer reference or invoke it, as its responsibilities are now handled elsewhere. [1] [2] [3] [4]QEMU VM management enhancements:
hack/qemu/vm.shto support native L2 networking on macOS usingvmnet-shared(with automatic MAC address assignment and DHCP IP discovery), and clarified networking differences between macOS and Linux in both the script and usage documentation. The script now properly handles SSH connection details and process management for both platforms, including necessary privilege escalation on macOS. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]Documentation:
KubadmNodeJoin→KubeadmNodeJoin).