Skip to content

CSHLD-1430: BitGoJS SDK — Add shielded wallet creation support - #9524

Draft
Ranjna-G wants to merge 1 commit into
masterfrom
CSHLD-1430-add-shielded-wallet-support
Draft

CSHLD-1430: BitGoJS SDK — Add shielded wallet creation support#9524
Ranjna-G wants to merge 1 commit into
masterfrom
CSHLD-1430-add-shielded-wallet-support

Conversation

@Ranjna-G

Copy link
Copy Markdown
Contributor

Summary

Adds isShielded flag support for custodial wallet creation, enabling shielded Zcash (zec/tzec) wallet generation through wallet-platform. Includes validation to restrict shielded wallets to custodial type and require enterprise parameter.

Linear: CSHLD-1430

Changes

  • Add isShielded optional property to GenerateBaseMpcWalletOptions and GenerateWalletOptions interfaces
  • Implement shielded wallet generation logic in generateWallet method with validation checks
  • Pass isShielded flag through to wallet-platform API via coinSpecific parameter
  • Add comprehensive test coverage for shielded wallet creation (success case and error cases)

Test Plan

Unit tests added covering:

  • Creating a custodial shielded wallet with proper parameters
  • Rejecting non-custodial shielded wallet creation attempt
  • Rejecting shielded wallet without enterprise parameter

CLOSES TICKET: CSHLD-1430

@linear-code

linear-code Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor
@Ranjna-G Ranjna-G changed the title CSHLD-1430: Task 2.9: BitGoJS SDK — Add shielded wallet creation support Aug 19, 2026
Adds isShielded flag support for custodial wallet creation, enabling
shielded Zcash (zec/tzec) wallet generation through wallet-platform.
Includes validation to restrict shielded wallets to custodial type and
require enterprise parameter. Adds comprehensive test coverage for both
success and error cases.

Ticket: CSHLD-1430
@Ranjna-G
Ranjna-G force-pushed the CSHLD-1430-add-shielded-wallet-support branch from 5b4270f to a7c59b9 Compare September 1, 2026 08:03
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

⚠️ Unit tests are failing on Node 26.x (Current release line, non-blocking). This is not an LTS version yet, so it does not block merge, but it signals an incompatibility to fix before Node 26.x becomes LTS.

View run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant