test(sdk-lib-mpc): add EdDSA MPCv2 keyshare wire-format regression - #9617
Draft
vibhavgo wants to merge 1 commit into
Draft
test(sdk-lib-mpc): add EdDSA MPCv2 keyshare wire-format regression#9617vibhavgo wants to merge 1 commit into
vibhavgo wants to merge 1 commit into
Conversation
Contributor
Contributor
|
|
vibhavgo
force-pushed
the
WCI-1476-eddsa-mpcv2-wire-format-regression
branch
from
September 1, 2026 07:34
1c9e6fd to
b2b22ab
Compare
Check in a static DKG keyshare fixture (bincode-serialized Keyshare<EdwardsPoint>, generated 2026-09-01 from @bitgo/sdk-lib-mpc @10.18.0) and a regression test that loads it through DSG and verifies the resulting Ed25519 signature. If wasm-mps changes its bincode layout or the multi-party-schnorr Keyshare<G> struct gains new fields via Cargo feature unification, DSG round 0 deserialization fails and CI catches the breaking change before it reaches production. Ticket: WCI-1476
vibhavgo
force-pushed
the
WCI-1476-eddsa-mpcv2-wire-format-regression
branch
from
September 1, 2026 07:43
b2b22ab to
54f0a0d
Compare
vibhavgo
marked this pull request as ready for review
September 1, 2026 08:20
vibhavgo
marked this pull request as draft
September 1, 2026 10:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check in a static DKG keyshare fixture (bincode-serialized Keyshare, generated 2026-09-01 from @bitgo/sdk-lib-mpc @10.18.0) and a regression test that loads it through DSG and verifies the resulting Ed25519 signature. If wasm-mps changes its bincode layout or the multi-party-schnorr Keyshare struct gains new fields via Cargo feature unification, DSG round 0 deserialization fails and CI catches the breaking change before it reaches production.
Ticket: WCI-1476