test(hive): fix assertEqual signature — all 5 hive tests green on emulator - #22
Merged
Merged
Conversation
KeepKeyTest overrides assertEqual(self, lhs, rhs) with no msg parameter, so the 3-arg calls raised TypeError. Verified: all 5 tests pass against the feature/hive emulator (build-emu/bin/kkemu, fw 7.15.0) — get_public_key(s), sign_tx, sign_account_create, sign_account_update, with signature recovery + full serialized_tx field-binding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #21.
KeepKeyTestoverridesassertEqual(self, lhs, rhs)with nomsgparameter, so the field-bindingassertEqual(a, b, "label")calls raisedTypeError. Drops the message args.Verified on the feature/hive emulator (
build-emu/bin/kkemu, fw 7.15.0, UDP transport + DebugLink auto-confirm):The signing tests pass with signature recovery (recovers to the device owner/active key) and full
serialized_txfield-binding (creator, account name, each role key in its authority slot). This empirically validates the attestation-digest contract (keepkey-vaultdocs/HIVE-ATTESTATION-DIGEST-SPEC.md) against real firmware.