feat: add Zcash Orchard protocol + v5/NU6 test suite - #4
Closed
BitHighlander wants to merge 2 commits into
Closed
Conversation
- Generate messages_solana_pb2.py via docker_build_pb.sh (protoc 3.5.1) - Regenerate messages_pb2.py with Solana MessageType entries (750-755) - Add solana_get_address, solana_sign_tx, solana_sign_message to client - Add Solana mapping in mapping.py - Point device-protocol submodule at feature-solana (messages-solana.proto) - Add messages-solana to build_pb.sh proto generation list Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Protocol: - Add messages-zcash.proto (6 message types: SignPCZT, PCZTAction, PCZTActionAck, SignedPCZT, GetOrchardFVK, OrchardFVK) - Update messages.proto with Zcash message type enums (1300-1305) - Regenerate pb2 files via Docker (protoc 3.5.1) - Update build_pb.sh to include messages-zcash Client: - Add zcash_get_orchard_fvk() for Orchard Full Viewing Key derivation - Add zcash_sign_pczt() for Orchard spend authorization with streaming action protocol (ZcashPCZTActionAck flow control) Tests (from markrypt0 firmware integration work): - test_zcash_v5_complete: v5 signing with script_pubkey (ZIP-244) - test_zcash_nu6: NU6 integration test via emulator - test_nu6_final: v5 + NU6 broadcast test with auto UTXO lookup - test_zcash_complete_nownodes: full workflow with NOWNodes API - verify_zip244: pure Python ZIP-244 sighash reference impl - zcash_rpc: zcashd node RPC client utility
Owner
Author
|
Superseded by combined release PR #13 which includes all 7.14.0 content. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
messages-zcash.protowith Orchard PCZT protocol (6 message types)build_pb.shto includemessages-zcashin protoc buildmessages_pb2.pyand generatemessages_zcash_pb2.py(protoc 3.5.1 via Docker)zcash_get_orchard_fvk()andzcash_sign_pczt()client methodsTest scripts
test_zcash_v5_complete.py: v5 signing with script_pubkey (ZIP-244 critical fix)test_zcash_nu6.py: NU6 integration test via emulatortest_nu6_final.py: v5 + NU6 auto-broadcast testtest_zcash_complete_nownodes.py: full workflow with NOWNodes APIverify_zip244.py: pure Python ZIP-244 sighash referencezcash_rpc.py: zcashd node RPC clientTest plan
docker_build_pb.shcompletes without errorsmessages_zcash_pb2.pyimports cleanlyclient.zcash_get_orchard_fvk()sends ZcashGetOrchardFVK messageclient.zcash_sign_pczt()handles ZcashPCZTActionAck streaming