fix: pass --repo to mutating gh pr commands in dependabot merger script - #4825
Open
oksanaphmn wants to merge 1 commit into
Open
fix: pass --repo to mutating gh pr commands in dependabot merger script#4825oksanaphmn wants to merge 1 commit into
oksanaphmn wants to merge 1 commit into
Conversation
Mutating commands (review/merge/comment) resolved the target repo from git context instead of the explicit BuilderIO/builder scope used for search. Could target the wrong repo/PR if run outside this repo's git context, especially risky for the --admin force-merge path.
|
Contributor
|
Review Agent skipped this PR — @oksanaphmn doesn't have a Builder seat in this space. If you're @oksanaphmn: you may already have a seat under a different GitHub account. Reconnect GitHub If you're an admin: Add @oksanaphmn to this space |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a critical bug where mutating gh pr commands could resolve the repository from the current git context instead of BuilderIO/builder. Added a shared REPO constant and passed --repo=${REPO} to all mutating commands to ensure they always target the correct repository.
Note
Low Risk
Dev-only maintenance script change with no production runtime impact; reduces risk of approving or merging the wrong repository when run outside the builder checkout.
Overview
Fixes the dependabot PR merger so approve, auto-merge, admin force-merge, and Dependabot rebase comment steps always run against
BuilderIO/builderinstead of whatever repoghinfers from the current working directory.Introduces a shared
REPOconstant and adds--repo=${REPO}to those mutatinggh prinvocations. PR discovery already scoped the repo; this aligns write operations with that behavior.Reviewed by Cursor Bugbot for commit 77254f9. Bugbot is set up for automated code reviews on this repo. Configure here.