fix[sdk][studio]: ENG-13439 boolean targeting in Builder Studio - #4830
fix[sdk][studio]: ENG-13439 boolean targeting in Builder Studio#4830floating-dynamo wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: b9861b0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
View your CI Pipeline Execution ↗ for commit b9861b0
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
There was a problem hiding this comment.
Builder reviewed your changes — looks good ✅
Review Details
Code Review Summary
PR #4830 fixes Builder Studio preview targeting by normalizing the URL-derived builder.userAttributes.* values "true" and "false" into JSON booleans before the Content API URL is generated. The implementation is narrowly scoped to the existing BUILDER_STUDIO path, preserves other attribute values, and continues to add the current pathname and host. The regression test covers both boolean values, a regular string attribute, and the generated context attributes. The changeset includes the affected SDK packages.
Risk assessment: Low. This is a focused SDK preview-parsing change with no authentication, persistence, mutation, or API-contract changes.
No confirmed bugs were found by either parallel code-review agent. The test suite was not executed because the workspace dependency setup failed while building isolated-vm; this is an environment limitation rather than a finding in the patch.
🧪 Browser testing: Skipped — dev server unavailable on HEAD due to failed workspace setup (isolated-vm build failure and no dev command configured). Will retry on the next incremental review.
Description
"true"and"false"back to booleans before sending the Content API request.Link to JIRA ticket (if applicable):
https://builder-io.atlassian.net/browse/ENG-13439
Screenshot/Clip
Clip - https://clips.agent-native.com/share/A3fWy4lLi4dJ?ref=clip_share
Note
Low Risk
Small, Studio-preview-only change to query parsing with a focused unit test; no auth or persistence impact.
Overview
Fixes boolean targeting in Builder Studio preview by normalizing user-attribute query values before they are sent to the Content API.
When
preview=BUILDER_STUDIO,builder.userAttributes.*URL params are parsed viaparseStudioUserAttribute, which turns string"true"/"false"into real booleans (other values stay unchanged). A test covers mixed boolean and string attributes plus the existingurlPath/hostinjection.Patch bumps all framework SDK packages via changeset.
Reviewed by Cursor Bugbot for commit b9861b0. Bugbot is set up for automated code reviews on this repo. Configure here.