Quit instantly when no items marked for deletion

[Copilot]

Pressing 'q' in the main view previously required two confirmations regardless of whether items were marked for deletion. This added unnecessary friction when no destructive action was pending.

Changes

Modified handle_quit() in src/interactive/app/eventloop.rs:

• Quit instantly when window.mark_pane.is_none() (no deletion risk)
• Preserve two-press confirmation when items are marked (safety measure for destructive operations)

Main => {
    if self.glob_navigation.is_some() {
        self.quit_glob_mode(tree_view, window);
    } else if window.mark_pane.is_none() {
        // Quit instantly when nothing is marked for deletion
        return Some(Ok(WalkResult {
            num_errors: self.stats.io_errors,
        }));
    } else if !self.pending_exit {
        self.pending_exit = true;
    } else {
        return Some(Ok(WalkResult {
            num_errors: self.stats.io_errors,
        }));
    }
}

Added tests covering both instant quit and two-press scenarios.

Original prompt

When pressing 'q' and nothing is selected for deletion, quit instantly.

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

[cuviper]

Note that this version requires Rust 1.88, contrary to your own MSRV 1.83.

You could use CARGO_RESOLVER_INCOMPATIBLE_RUST_VERSIONS=fallback when updating your lockfile to avoid this automatically.

[Byron]

Thanks for the hint!

I would have thought that if Cargo treats rust-version as MSRV, it would automatically assure version updates don't violate it.
Personally, I didn't think of it as MSRV, just as the minimal version that is needed to build the application code, just as a service to those who want to build it themselves.

If dependencies aren't adhering to it, I'd rather remove the field, I think.
Does that make sense?

[cuviper]

I would have thought that if Cargo treats rust-version as MSRV, it would automatically assure version updates don't violate it.

That's what the fallback resolver is about, but it's relatively new. You can opt into this more directly starting in 1.84, and it's the default in 2024 edition (1.85+).
https://blog.rust-lang.org/2025/01/09/Rust-1.84.0/#cargo-considers-rust-versions-for-dependency-version-selection

Personally, I didn't think of it as MSRV, just as the minimal version that is needed to build the application code, just as a service to those who want to build it themselves.

If dependencies aren't adhering to it, I'd rather remove the field, I think. Does that make sense?

Even as just a hint, I think it's still useful to keep, but maybe it would be worth adding a CI job for it so you know when it needs to be increased.

I don't think it's a big deal for dependencies to raise their MSRV now that we have a resolver that deals with it, and you don't necessarily need to follow them if you're not using new features too. It's up to you!

[Byron]

Then I think it's fixed now - I intuitively removed that version field and added edition = 2024. But from what I read here, it seems it can be re-added to protect against new lints showing up unexpectedly.

In any case, thanks for all your help, it was quite inspirational.