Skip to content

Improve GeoJSON document error reporting #726

Description

@j9liu

Feature

#706 introduced the ability to load polygons from GeoJSON into a CesiumCartographicPolygon's spline. However, the ion troubleshooting window does not quite work for assets loaded from Cesium ion. This is because the current GeoJSON API does not surface the error codes necessary to report this in the ion troubleshooting window.

Per @gojushin's comment:

Implementing the auto-refreshing, using wrong datasets (e.g. an asset ID pointing to a 3DTileset instead of a GeoJSON document) causes the troubleshooting window to open and report "everything OK" across the board while nothing indicated that the wrong type of asset was being loaded.

In short: To implement this cleanly we NEED status codes.

GeoJsonDocument::fromCesiumIonAsset and GeoJsonDocument::fromUrl do however never surface them, besides baking them into a ErrorMessage in ErrorList (see: GeoJsonDocument.cpp L639-L641). It would be cleanest to expose them in Native first.....

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions