Skip to content

Return pick ray in world coordinates with orthographic frustum #12500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 10, 2025
Merged

Return pick ray in world coordinates with orthographic frustum #12500

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2bc4d4d
Return pick ray in world coordinates with orthographic frustum
andrewda Feb 28, 2025
9665112
Add pick ray with lookAt tests
andrewda Feb 28, 2025
231f91e
Add pick ray Columbus view test
andrewda Feb 28, 2025
236bb3b
Fix epsilon values
andrewda Feb 28, 2025
d4431ca
Update CHANGES.md
andrewda Feb 28, 2025
6fde8d6
Merge branch 'main' into pick-ray-orthographic
ggetz Mar 10, 2025
81e4fea
Add update instructions to breaking changes message
ggetz Mar 10, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix epsilon values
  • Loading branch information
@andrewda
andrewda committed Feb 28, 2025
commit 236bb3b95feaa95a7b5d7a57ba68a602b505c8b0
12 changes: 6 additions & 6 deletions packages/engine/Specs/Scene/CameraSpec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3205,7 +3205,7 @@ describe("Scene/Camera", function () {
cameraPosition.y + 2.0,
cameraPosition.z + 2.0,
);
expect(ray.origin).toEqualEpsilon(expectedPosition, CesiumMath.EPSILON16);
expect(ray.origin).toEqualEpsilon(expectedPosition, CesiumMath.EPSILON14);
expect(ray.direction).toEqual(camera.directionWC);
});

Expand Down Expand Up @@ -3234,7 +3234,7 @@ describe("Scene/Camera", function () {
cameraPosition.y + 2.0,
cameraPosition.z,
);
expect(ray.origin).toEqualEpsilon(expectedPosition, CesiumMath.EPSILON18);
expect(ray.origin).toEqualEpsilon(expectedPosition, CesiumMath.EPSILON14);
expect(ray.direction).toEqual(camera.directionWC);
});

Expand Down Expand Up @@ -3389,11 +3389,11 @@ describe("Scene/Camera", function () {

const cameraPosition = tempCamera.positionWC;
const expectedPosition = new Cartesian3(
cameraPosition.x,
cameraPosition.y + 2.0,
cameraPosition.z + 2.0,
cameraPosition.x + 2.0,
cameraPosition.y - 2.0,
cameraPosition.z,
);
expect(ray.origin).toEqualEpsilon(expectedPosition, CesiumMath.EPSILON16);
expect(ray.origin).toEqualEpsilon(expectedPosition, CesiumMath.EPSILON6);
expect(ray.direction).toEqual(tempCamera.directionWC);
});

Expand Down