Hot patch to fix #158 (take 2) - #161
Merged
Merged
Conversation
geneorama
reviewed
Jan 25, 2019
geneorama
left a comment
geneorama
left a comment
Member
There was a problem hiding this comment.
Nick, it looks like you’ve already submitted 1.7.5-3, correct?
Member
|
My preference would be to close the connections within the function calls in which they are used rather than in the examples. However if it's already submitted to CRAN then I don't really have the option to propose changes for this release of master, because we can't resubmit for some time. |
geneorama
approved these changes
Jan 25, 2019
Contributor
Author
|
This is on CRAN now. I'll create a new release and rebase dev. Thanks! |
nicklucius
added a commit
that referenced
this pull request
Jan 28, 2019
Merge remote-tracking branch 'origin/dev' # Conflicts: # DESCRIPTION
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes a
textConnectionthat was left open at the end of Example code forread.socrata(). All tests are passing now, including R-devel.