Skip to content

Fix End of Doc Bugs - #112

Merged
thecoolwinter merged 2 commits into
CodeEditApp:mainfrom
thecoolwinter:fix/end-of-doc-bug
Jun 26, 2025
Merged

Fix End of Doc Bugs#112
thecoolwinter merged 2 commits into
CodeEditApp:mainfrom
thecoolwinter:fix/end-of-doc-bug

Conversation

@thecoolwinter

@thecoolwinter thecoolwinter commented Jun 26, 2025

Copy link
Copy Markdown
Contributor

Description

Fixes a few end-of-document bugs:

  • rectForOffset had an incorrect != instead of a < check for the end of the document.
  • mouseDown needed to be looser on finding content runs for the end of documents.

Adds test cases that would have caught both these bugs.

Related Issues

N/A

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

N/A

@thecoolwinter
thecoolwinter merged commit 80fb884 into CodeEditApp:main Jun 26, 2025
@thecoolwinter
thecoolwinter deleted the fix/end-of-doc-bug branch June 26, 2025 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant