Skip to content

(fix: #32) Fix Deleting Selected Range - #33

Merged
austincondiff merged 1 commit into
CodeEditApp:mainfrom
thecoolwinter:fix/delete-range
May 21, 2024
Merged

(fix: #32) Fix Deleting Selected Range#33
austincondiff merged 1 commit into
CodeEditApp:mainfrom
thecoolwinter:fix/delete-range

Conversation

@thecoolwinter

@thecoolwinter thecoolwinter commented May 18, 2024

Copy link
Copy Markdown
Contributor

Description

Fixes deleting a selected range, before would extend the selection range when deleting no matter what. This fixes it to only extend the range if it's a cursor rather than a selected range.

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

Screen.Recording.2024-05-18.at.9.58.16.AM.mov

@austincondiff austincondiff left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@austincondiff
austincondiff merged commit 80911be into CodeEditApp:main May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants